This repository has been archived by the owner on Oct 7, 2020. It is now read-only.
Prepare for 0.9.0.0 release #1227
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fendor
approved these changes
May 1, 2019
michaelpj
approved these changes
May 1, 2019
3 tasks
lukel97
approved these changes
May 1, 2019
infinisil
reviewed
May 1, 2019
Changelog.md
Outdated
| - GHC 8.6.5 preliminary support added via the nightly build (@alanz) | ||
| - Add `diagnosticsOnChange` config parameter, default `True` | ||
| (preserving prior hie behaviour). Setting it `False` only generates | ||
| diagnostics on file save. (#1164, @mpickering/@lorenzo) |
There was a problem hiding this comment.
It would be nice if these PR numbers were clickable. A find-and-replace incantation should do it (#1164 -> [#1164](https://github.com/haskell/haskell-ide-engine/issues/1164))
|
Damn, I thought github was clever enough to do that. That was my intention.
…On Wed, 01 May 2019, 22:43 Silvan Mosberger, ***@***.***> wrote:
***@***.**** commented on this pull request.
------------------------------
In Changelog.md
<#1227 (comment)>
:
> @@ -1,3 +1,44 @@
+# 0.9.0.0
+
+- GHC 8.6.5 preliminary support added via the nightly build ***@***.***)
+- Add `diagnosticsOnChange` config parameter, default `True`
+ (preserving prior hie behaviour). Setting it `False` only generates
+ diagnostics on file save. (#1164, @***@***.***)
It would be nice if these PR numbers were clickable. A find-and-replace
incantation should do it.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
<#1227 (review)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AADEABZWGJPXB36X7TLPBNDPTH6HZANCNFSM4HJS4VVA>
.
|
|
@bubba please tag and release this when CI passes, I will be spottily available the next 2 days |
|
Snapshot bumping line is missing. We have already bumped 8.6.4 and may bump 8.6.3 due to #1236 |
|
Older versions have it in the following format:
In our case it's
|
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.