Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support structured diagnostics 2 #4433

Open
wants to merge 44 commits into
base: master
Choose a base branch
from
Open

Support structured diagnostics 2 #4433

wants to merge 44 commits into from

Commits on Oct 17, 2024

  1. Change FileDiagnostic type synonym to a datatype

    @dylan-thinnes @noughtmare
    dylan-thinnes authored and noughtmare committed Oct 17, 2024
    Configuration menu
    Copy the full SHA
    44cf722 View commit details
    Browse the repository at this point in the history

  2. Make ideErrorWithSource produce FileDiagnostic by adding filepath arg

    @dylan-thinnes @noughtmare
    dylan-thinnes authored and noughtmare committed Oct 17, 2024
    Configuration menu
    Copy the full SHA
    789977d View commit details
    Browse the repository at this point in the history

  3. Supply structured error wherever we easily can - TODOs for hard parts 

    We're leaving the TODOs for either later in this PR or in another PR
    @dylan-thinnes @noughtmare
    dylan-thinnes authored and noughtmare committed Oct 17, 2024
    Configuration menu
    Copy the full SHA
    e9d1c68 View commit details
    Browse the repository at this point in the history

  4. Fix UnitTests for new FileDiagnostic struct

    @dylan-thinnes @noughtmare
    dylan-thinnes authored and noughtmare committed Oct 17, 2024
    Configuration menu
    Copy the full SHA
    176e626 View commit details
    Browse the repository at this point in the history

  5. Remove explicit uses of FileDiagnostic, add codes to LSP diagnostics

    @dylan-thinnes @noughtmare
    dylan-thinnes authored and noughtmare committed Oct 17, 2024
    Configuration menu
    Copy the full SHA
    2e03927 View commit details
    Browse the repository at this point in the history

  6. Add field for expected error codes in ghcide tests

    @dylan-thinnes @noughtmare
    dylan-thinnes authored and noughtmare committed Oct 17, 2024
    Configuration menu
    Copy the full SHA
    3ce7019 View commit details
    Browse the repository at this point in the history

  7. Expect GHC-83865 for "type error" test - basic test

    @dylan-thinnes @noughtmare
    dylan-thinnes authored and noughtmare committed Oct 17, 2024
    Configuration menu
    Copy the full SHA
    11fdd87 View commit details
    Browse the repository at this point in the history

  8. Return structured warnings in TcModuleResult by copying from Driver

    @dylan-thinnes @noughtmare
    dylan-thinnes authored and noughtmare committed Oct 17, 2024
    Configuration menu
    Copy the full SHA
    ac17800 View commit details
    Browse the repository at this point in the history

  9. Store FileDiagnostic instead of LSP Diagnostic in Shake store

    @dylan-thinnes @noughtmare
    dylan-thinnes authored and noughtmare committed Oct 17, 2024
    Configuration menu
    Copy the full SHA
    59abf29 View commit details
    Browse the repository at this point in the history

  10. Add expected error codes for diagnostics that have them

    @dylan-thinnes @noughtmare
    dylan-thinnes authored and noughtmare committed Oct 17, 2024
    Configuration menu
    Copy the full SHA
    861170a View commit details
    Browse the repository at this point in the history

  11. Dispatch TODOs, amend remaining TODOs as future work

    @dylan-thinnes @noughtmare
    dylan-thinnes authored and noughtmare committed Oct 17, 2024
    Configuration menu
    Copy the full SHA
    441a323 View commit details
    Browse the repository at this point in the history

  12. Add scary comments all over copied code in Compat.Driver

    @dylan-thinnes @noughtmare
    dylan-thinnes authored and noughtmare committed Oct 17, 2024
    Configuration menu
    Copy the full SHA
    34618b8 View commit details
    Browse the repository at this point in the history

  13. Update all remaining diagnostics that could use an expected error code

    @dylan-thinnes @noughtmare
    dylan-thinnes authored and noughtmare committed Oct 17, 2024
    Configuration menu
    Copy the full SHA
    a1769a8 View commit details
    Browse the repository at this point in the history

  14. Add _code to pretty printing for FileDiagnostic

    @dylan-thinnes @noughtmare
    dylan-thinnes authored and noughtmare committed Oct 17, 2024
    Configuration menu
    Copy the full SHA
    ac5b8bb View commit details
    Browse the repository at this point in the history

  15. Use case instead of maybe for StructuredMessage match

    @dylan-thinnes @noughtmare
    dylan-thinnes authored and noughtmare committed Oct 17, 2024
    Configuration menu
    Copy the full SHA
    7b8f271 View commit details
    Browse the repository at this point in the history

  16. Use CPP to prevent setting _code before structured errors

    @dylan-thinnes @noughtmare
    dylan-thinnes authored and noughtmare committed Oct 17, 2024
    Configuration menu
    Copy the full SHA
    037ca0a View commit details
    Browse the repository at this point in the history

  17. Swap modifier for lenses, document StructuredMessage type

    @dylan-thinnes @noughtmare
    dylan-thinnes authored and noughtmare committed Oct 17, 2024
    Configuration menu
    Copy the full SHA
    8662431 View commit details
    Browse the repository at this point in the history

  18. Add link to Issue & MR to Compat.Driver

    @dylan-thinnes @noughtmare
    dylan-thinnes authored and noughtmare committed Oct 17, 2024
    Configuration menu
    Copy the full SHA
    676ef8f View commit details
    Browse the repository at this point in the history

  19. Drop attachReason logic from withWarnings, technically incorrect

    @dylan-thinnes @noughtmare
    dylan-thinnes authored and noughtmare committed Oct 17, 2024
    Configuration menu
    Copy the full SHA
    6b5b043 View commit details
    Browse the repository at this point in the history

  20. Revert "Drop attachReason logic", needed by pragmas-plugin 

    This reverts commit 4fed987.
    @dylan-thinnes @noughtmare
    dylan-thinnes authored and noughtmare committed Oct 17, 2024
    Configuration menu
    Copy the full SHA
    36fd84e View commit details
    Browse the repository at this point in the history

  21. Fix plugins where necessary for new diagnostic structure

    @dylan-thinnes @noughtmare
    dylan-thinnes authored and noughtmare committed Oct 17, 2024
    Configuration menu
    Copy the full SHA
    2868e83 View commit details
    Browse the repository at this point in the history

  22. Fix build issues with other tests from expectDiagnostics

    @dylan-thinnes @noughtmare
    dylan-thinnes authored and noughtmare committed Oct 17, 2024
    Configuration menu
    Copy the full SHA
    7d4cf38 View commit details
    Browse the repository at this point in the history

  23. Improve comment on metadata fdStructuredMessage in FileDiagnostic

    @dylan-thinnes @noughtmare
    dylan-thinnes authored and noughtmare committed Oct 17, 2024
    Configuration menu
    Copy the full SHA
    dafb559 View commit details
    Browse the repository at this point in the history

  24. Add note to withWarnings explaining the current state of things

    @dylan-thinnes @noughtmare
    dylan-thinnes authored and noughtmare committed Oct 17, 2024
    Configuration menu
    Copy the full SHA
    d904b98 View commit details
    Browse the repository at this point in the history

  25. Attach reasons into data field of LSP Diagnostic instead of code field 

    Had to move `attachReason` between modules to achieve this, which is
fine because it was never exported from its own module.
    @dylan-thinnes @noughtmare
    dylan-thinnes authored and noughtmare committed Oct 17, 2024
    Configuration menu
    Copy the full SHA
    27c36cf View commit details
    Browse the repository at this point in the history

  26. Fix up mistakes from merge, TODO fix merge issues for 9.3.0

    @dylan-thinnes @noughtmare
    dylan-thinnes authored and noughtmare committed Oct 17, 2024
    Configuration menu
    Copy the full SHA
    3961148 View commit details
    Browse the repository at this point in the history

  27. Set CodeDescription from HaskellErrorIndex when available

    @dylan-thinnes @noughtmare
    dylan-thinnes authored and noughtmare committed Oct 17, 2024
    Configuration menu
    Copy the full SHA
    0aa6aaa View commit details
    Browse the repository at this point in the history

  28. Remove debugging print, fix expectation for preprocessor tests

    @dylan-thinnes @noughtmare
    dylan-thinnes authored and noughtmare committed Oct 17, 2024
    Configuration menu
    Copy the full SHA
    c14cee6 View commit details
    Browse the repository at this point in the history

  29. Fix CPP for using Show instance on DiagnosticCode

    @dylan-thinnes @noughtmare
    dylan-thinnes authored and noughtmare committed Oct 17, 2024
    Configuration menu
    Copy the full SHA
    7a6e00e View commit details
    Browse the repository at this point in the history

  30. Remove diagFromErrMsgs for GHC version < 9.6.1 using CPP

    @dylan-thinnes @noughtmare
    dylan-thinnes authored and noughtmare committed Oct 17, 2024
    Configuration menu
    Copy the full SHA
    a8a7a64 View commit details
    Browse the repository at this point in the history

  31. CPP fix

    @dylan-thinnes @noughtmare
    dylan-thinnes authored and noughtmare committed Oct 17, 2024
    Configuration menu
    Copy the full SHA
    14fbd7c View commit details
    Browse the repository at this point in the history

  32. More stylish-haskell, more CPP fix

    @dylan-thinnes @noughtmare
    dylan-thinnes authored and noughtmare committed Oct 17, 2024
    Configuration menu
    Copy the full SHA
    61164ea View commit details
    Browse the repository at this point in the history

  33. Fix all stylish-haskell errors triggering

    @dylan-thinnes @noughtmare
    dylan-thinnes authored and noughtmare committed Oct 17, 2024
    Configuration menu
    Copy the full SHA
    53221ff View commit details
    Browse the repository at this point in the history

  34. Fix more CPP

    @dylan-thinnes @noughtmare
    dylan-thinnes authored and noughtmare committed Oct 17, 2024
    Configuration menu
    Copy the full SHA
    4d1742e View commit details
    Browse the repository at this point in the history

  35. Only override the LSP diagnostic code when not already set

    @dylan-thinnes @noughtmare
    dylan-thinnes authored and noughtmare committed Oct 17, 2024
    Configuration menu
    Copy the full SHA
    8b229fc View commit details
    Browse the repository at this point in the history

  36. Fixes for stylish-haskell 

    stylish-haskell does not handle CPP pragmas very well, is this a
regression?
    @dylan-thinnes @noughtmare
    dylan-thinnes authored and noughtmare committed Oct 17, 2024
    Configuration menu
    Copy the full SHA
    296b847 View commit details
    Browse the repository at this point in the history

  37. Qualify s, t for FuzzySearch

    @dylan-thinnes @noughtmare
    dylan-thinnes authored and noughtmare committed Oct 17, 2024
    Configuration menu
    Copy the full SHA
    dd3da46 View commit details
    Browse the repository at this point in the history

  38. Ignore use of unsafePerformIO in FuzzySearch

    @dylan-thinnes @noughtmare
    dylan-thinnes authored and noughtmare committed Oct 17, 2024
    Configuration menu
    Copy the full SHA
    4fd35fd View commit details
    Browse the repository at this point in the history

  39. Properly split GHC.Types.Error import in Diagnostics for stylish-haskell

    @dylan-thinnes @noughtmare
    dylan-thinnes authored and noughtmare committed Oct 17, 2024
    Configuration menu
    Copy the full SHA
    6a66ad2 View commit details
    Browse the repository at this point in the history

  40. Force type signature of annotation on FuzzySearch.dictionary

    @dylan-thinnes @noughtmare
    dylan-thinnes authored and noughtmare committed Oct 17, 2024
    Configuration menu
    Copy the full SHA
    679bc6b View commit details
    Browse the repository at this point in the history

  41. DRY up definition of closure_errs 

    From review haskell#4311 (comment)
    @dylan-thinnes @noughtmare
    dylan-thinnes authored and noughtmare committed Oct 17, 2024
    Configuration menu
    Copy the full SHA
    de8bfaa View commit details
    Browse the repository at this point in the history

  42. Remove unused imports

    @noughtmare
    noughtmare committed Oct 17, 2024
    Configuration menu
    Copy the full SHA
    5177e65 View commit details
    Browse the repository at this point in the history

  43. Post-rebase fixes

    @noughtmare
    noughtmare committed Oct 17, 2024
    Configuration menu
    Copy the full SHA
    e651d41 View commit details
    Browse the repository at this point in the history

  44. stylish-haskell formatting

    @noughtmare
    noughtmare committed Oct 17, 2024
    Configuration menu
    Copy the full SHA
    b627909 View commit details
    Browse the repository at this point in the history