Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use our normal auto-incrementing ids instead of UUIDs #578

Merged
merged 2 commits into from
May 18, 2024
Merged

Conversation

michaelpj
Copy link
Collaborator

The spec just says they have to be unique IDs, not UUIDs, and we already have a tool for generating such things.

The spec just says they have to be unique IDs, not UUIDs, and we already
have a tool for generating such things.
Copy link
Contributor

@SquidDev SquidDev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is much nicer, thank you! Can we drop the random dependency too now?

@soulomoon soulomoon self-requested a review May 17, 2024 16:37
Copy link
Collaborator

@soulomoon soulomoon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@michaelpj
Copy link
Collaborator Author

Yes, we can also remove random. great.

@michaelpj michaelpj enabled auto-merge (squash) May 18, 2024 11:00
@michaelpj michaelpj merged commit 6327e0f into master May 18, 2024
16 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants