Feature/update by pk #169
Merged
Feature/update by pk #169
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hasura/graphql-engine:v2.15.1.cli-migrations-v3 is no longer present in dockerhub
Was required in order to link the local ra-data-hasura without runtime issues
|
@praveenweb or @arjunyel could you have a look at this? |
praveenweb
approved these changes
Apr 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Today the data provider is using the update many query in hasura to update single entries. This led to a critical bug in production for one of the companies I'm developing for, where all records were updated. This is because update many actually runs without the id column in the where clause being present!
With update_resource_by_pk hasura actually requires the pk_columns to be set, and this behaviour is no longer possible.
Also update by pk is more db-efficient and should lead to easier graphql debugging for anyone experiencing issues.
NOTE: this should be considered a minor version, as it has the potential to break existing implementations that are extending the package with custom buildVariables for the UPDATE queries