Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Deliver notification on input source change #9

Merged
merged 1 commit into from
Sep 14, 2017
Merged

Deliver notification on input source change #9

merged 1 commit into from
Sep 14, 2017

Conversation

humblehacker
Copy link
Contributor

Also replace key to Settings with an enum

@humblehacker
Deliver notification on input source change
f409744 
Also replace key to Settings with an enum
@humblehacker
Copy link
Contributor Author

Is there anything I can change to have this PR accepted?

@hatashiro hatashiro merged commit 67dae03 into hatashiro:master Sep 14, 2017
@hatashiro
Copy link
Owner

Sorry for the late reaction. Thanks!

hatashiro pushed a commit that referenced this pull request Sep 16, 2017
Release v1.0.0
16cc189 
* Add an option to show macOS notification on source change (#9)
* Implement a proper workaround for the known CJKV bug (#12)
* Update licenses for 2017
* Minor code refactoring
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@humblehacker @hatashiro