maitake: fix rust-lang/miri#3780, actually run Miri on CI #483
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reproduces a potential UB where a `task::Cell` gets niche-optimized in the `Joined` case. This is based on the test added to Tokio in tokio-rs/tokio#6744
See [this comment][1]. Adding `#[repr(C)]` to this type suppresses niche optimization, resolving potential unsoundness that could occur when the compiler decides to niche-optimize a self-referential future type. In practice this probably doesn't actually happen, but we should make sure it never does. [1]: rust-lang/miri#3780 (comment)
It turns out CI only ever runs Miri tests for `cordyceps`, not `maitake`/`maitake-sync`. MY BAD LOL. This PR fixes that. In doing so, I've also had to go through and change a bunch of tests to spawn fewer tasks when running under Miri, so that it doesn't take a really long time to run. Most of the issues we hope Miri catches don't actually depend on concurrency --- we have `loom` tests for that.
hawkw
changed the title
hawkw
added a commit
that referenced
this pull request
Aug 3, 2024
This reproduces a potential UB where a `task::Cell` gets niche-optimized in the `Joined` case. This is based on the test added to Tokio in tokio-rs/tokio#6744
hawkw
added a commit
that referenced
this pull request
Aug 3, 2024
See [this comment][1]. Adding `#[repr(C)]` to this type suppresses niche optimization, resolving potential unsoundness that could occur when the compiler decides to niche-optimize a self-referential future type. In practice this probably doesn't actually happen, but we should make sure it never does. [1]: rust-lang/miri#3780 (comment)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This reproduces a potential UB where a
task::Cellgets niche-optimized in theJoinedcase. This is based on the test added to Tokio in tokio-rs/tokio#6744