Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

List item picker actions #581

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

Shallowmallow
Copy link
Contributor

Added a dispatch SUBMIT event to the list views when there's a confirm action.
Added an ActionStart event to ItemPicker. I don't like it to much, feels it goes against the logic of the dynamic trigger event, but don't see how else to do it. (( In fact I feel maybe MouseEvents should also be action events, but that would too much of an undertaking :P)
No CANCEL action yet. I wonder if I should add directly to the listview. But don't feel it will be useful except in the case the listview is inside of an item picker

@ianharrigan
Copy link
Member

is "sumbit" the right event? What do normal listviews do, or dropdown for example, i think its just "change", no?

@Shallowmallow
Copy link
Contributor Author

Shallowmallow commented Feb 8, 2024 via email

@ianharrigan
Copy link
Member

i wonder if a generic "UIEvent.SELECTED" (or UIEvent.SELECT) makes more sense?

@Shallowmallow
Copy link
Contributor Author

Hmm, I think for normal list views SELECTED is good.
But let's suppose the list view is a multiselection one.
You press space to select one item, but you would press enter to validate the multi selection.
It would be weird that only the "enter" dispatches a SELECTED event.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants