Always put const at the end of type

include/tl2cgen/c_api_common.h

@@ -34,7 +34,7 @@ typedef void* TL2cgenDMatrixHandle;
  * Note. Each thread will get the last error occurred in its own context.
  * \return error string
  */
-TL2CGEN_DLL const char* TL2cgenGetLastError(void);
+TL2CGEN_DLL char const* TL2cgenGetLastError(void);
 
 /*!
  * \brief Register callback function for LOG(INFO) messages -- helpful messages
@@ -43,28 +43,28 @@ TL2CGEN_DLL const char* TL2cgenGetLastError(void);
  *       will run on the thread that registered it
  * \return 0 for success, -1 for failure
  */
-TL2CGEN_DLL int TL2cgenRegisterLogCallback(void (*callback)(const char*));
+TL2CGEN_DLL int TL2cgenRegisterLogCallback(void (*callback)(char const*));
 
 /*!
  * \brief Register callback function for LOG(WARNING) messages
  * Note: This function can be called by multiple threads. The callback function
  *       will run on the thread that registered it
  * \return 0 for success, -1 for failure
  */
-TL2CGEN_DLL int TL2cgenRegisterWarningCallback(void (*callback)(const char*));
+TL2CGEN_DLL int TL2cgenRegisterWarningCallback(void (*callback)(char const*));
 
 /*!
  * \brief Get the version string for the TL2cgen library.
  * \return version string, of form MAJOR.MINOR.PATCH
  */
-TL2CGEN_DLL const char* TL2cgenQueryTL2cgenVersion(void);
+TL2CGEN_DLL char const* TL2cgenQueryTL2cgenVersion(void);
 
 #ifdef __cplusplus
 extern "C" {
-extern const char* TREELITE_VERSION;
+extern char const* TREELITE_VERSION;
 }
 #else
-extern const char* TREELITE_VERSION;
+extern char const* TREELITE_VERSION;
 #endif
 
 #endif  // TL2CGEN_C_API_COMMON_H_

include/tl2cgen/c_api_error.h

@@ -38,13 +38,13 @@
  * \brief Set the last error message needed by C API
  * \param msg The error message to set.
  */
-void TL2cgenAPISetLastError(const char* msg);
+void TL2cgenAPISetLastError(char const* msg);
 /*!
  * \brief handle exception thrown out
  * \param e the exception
  * \return the return value of API after exception is handled
  */
-inline int TL2cgenAPIHandleException(const std::exception& e) {
+inline int TL2cgenAPIHandleException(std::exception const& e) {
   TL2cgenAPISetLastError(e.what());
   return -1;
 }

include/tl2cgen/error.h

@@ -16,7 +16,7 @@ namespace tl2cgen {
  * \brief Exception class that will be thrown by TL2cgen
  */
 struct Error : public std::runtime_error {
-  explicit Error(const std::string& s) : std::runtime_error(s) {}
+  explicit Error(std::string const& s) : std::runtime_error(s) {}
 };
 
 }  // namespace tl2cgen

include/tl2cgen/logging.h

@@ -20,7 +20,7 @@
 namespace tl2cgen {
 
 template <typename X, typename Y>
-std::unique_ptr<std::string> LogCheckFormat(const X& x, const Y& y) {
+std::unique_ptr<std::string> LogCheckFormat(X const& x, Y const& y) {
   std::ostringstream os;
   os << " (" << x << " vs. " << y << ") ";
   /* CHECK_XX(x, y) requires x and y can be serialized to string. Use CHECK(x OP y) otherwise. */
@@ -83,7 +83,7 @@ class DateLogger {
     _tzset();
 #endif  // defined(_MSC_VER)
   }
-  const char* HumanDate() {
+  char const* HumanDate() {
 #if defined(_MSC_VER)
     _strtime_s(buffer_, sizeof(buffer_));
 #else  // defined(_MSC_VER)
@@ -107,11 +107,11 @@ class DateLogger {
 
 class LogMessageFatal {
  public:
-  LogMessageFatal(const char* file, int line) {
+  LogMessageFatal(char const* file, int line) {
     log_stream_ << "[" << pretty_date_.HumanDate() << "] " << file << ":" << line << ": ";
   }
-  LogMessageFatal(const LogMessageFatal&) = delete;
-  void operator=(const LogMessageFatal&) = delete;
+  LogMessageFatal(LogMessageFatal const&) = delete;
+  void operator=(LogMessageFatal const&) = delete;
 
   std::ostringstream& stream() {
     return log_stream_;
@@ -127,7 +127,7 @@ class LogMessageFatal {
 
 class LogMessage {
  public:
-  LogMessage(const char* file, int line) {
+  LogMessage(char const* file, int line) {
     log_stream_ << "[" << DateLogger().HumanDate() << "] " << file << ":" << line << ": ";
   }
   ~LogMessage() {
@@ -136,15 +136,15 @@ class LogMessage {
   std::ostream& stream() {
     return log_stream_;
   }
-  static void Log(const std::string& msg);
+  static void Log(std::string const& msg);
 
  private:
   std::ostringstream log_stream_;
 };
 
 class LogMessageWarning {
  public:
-  LogMessageWarning(const char* file, int line) {
+  LogMessageWarning(char const* file, int line) {
     log_stream_ << "[" << DateLogger().HumanDate() << "] " << file << ":" << line << ": ";
   }
   ~LogMessageWarning() {
@@ -153,18 +153,18 @@ class LogMessageWarning {
   std::ostream& stream() {
     return log_stream_;
   }
-  static void Log(const std::string& msg);
+  static void Log(std::string const& msg);
 
  private:
   std::ostringstream log_stream_;
 };
 
 class LogCallbackRegistry {
  public:
-  using Callback = void (*)(const char*);
+  using Callback = void (*)(char const*);
   LogCallbackRegistry()
-      : log_callback_info_([](const char* msg) { std::cerr << msg << std::endl; }),
-        log_callback_warn_([](const char* msg) { std::cerr << msg << std::endl; }) {}
+      : log_callback_info_([](char const* msg) { std::cerr << msg << std::endl; }),
+        log_callback_warn_([](char const* msg) { std::cerr << msg << std::endl; }) {}
   inline void RegisterCallBackLogInfo(Callback log_callback) {
     this->log_callback_info_ = log_callback;
   }

src/.clang-format

@@ -55,3 +55,4 @@ SpacesInCStyleCastParentheses: false
 SpacesInContainerLiterals: false
 SpacesInParentheses: false
 SpacesInSquareBrackets: false
+QualifierAlignment: Right

src/c_api/c_api_common.cc

@@ -12,14 +12,14 @@
 
 using namespace tl2cgen;  // NOLINT(build/namespaces)
 
-int TL2cgenRegisterLogCallback(void (*callback)(const char*)) {
+int TL2cgenRegisterLogCallback(void (*callback)(char const*)) {
   API_BEGIN();
   LogCallbackRegistry* registry = LogCallbackRegistryStore::Get();
   registry->RegisterCallBackLogInfo(callback);
   API_END();
 }
 
-int TL2cgenRegisterWarningCallback(void (*callback)(const char*)) {
+int TL2cgenRegisterWarningCallback(void (*callback)(char const*)) {
   API_BEGIN();
   LogCallbackRegistry* registry = LogCallbackRegistryStore::Get();
   registry->RegisterCallBackLogWarning(callback);

src/c_api/c_api_error.cc

@@ -26,21 +26,21 @@ using TL2cgenAPIErrorStore = tl2cgen::ThreadLocalStore<TL2cgenAPIErrorEntry>;
 
 }  // anonymous namespace
 
-const char* TL2cgenGetLastError() {
+char const* TL2cgenGetLastError() {
   return TL2cgenAPIErrorStore::Get()->last_error.c_str();
 }
 
-void TL2cgenAPISetLastError(const char* msg) {
+void TL2cgenAPISetLastError(char const* msg) {
   TL2cgenAPIErrorStore::Get()->last_error = msg;
 }
 
-const char* TL2cgenQueryTL2cgenVersion() {
+char const* TL2cgenQueryTL2cgenVersion() {
   std::ostringstream oss;
   oss << TL2CGEN_VER_MAJOR << "." << TL2CGEN_VER_MINOR << "." << TL2CGEN_VER_PATCH;
   std::string& version_str = TL2cgenAPIErrorStore::Get()->version_str;
   version_str = oss.str();
   return version_str.c_str();
 }
 
-const char* TL2CGEN_VERSION = "TL2CGEN_VERSION_" STR(TREELITE_VER_MAJOR) "." STR(
+char const* TL2CGEN_VERSION = "TL2CGEN_VERSION_" STR(TREELITE_VER_MAJOR) "." STR(
     TREELITE_VER_MINOR) "." STR(TREELITE_VER_PATCH);