Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Resolves #1790 - use e.is_a? instead of e.message #1791

Closed
wants to merge 1 commit into from

Conversation

egeek
Copy link

@egeek egeek commented Sep 27, 2022

Switching to checking if the exception is a name error reduces the processing time for cases where a client application has extended how the exception processing works

…ocessing time for cases where a client application has extended how the exception processing works
@carlosantoniodasilva
Copy link
Member

Thanks @egeek, we're going to try an approach that doesn't rely on exception rescuing, but checks for const_defined? first: #1810. Let's see how it goes. it's on main now, let us know if that causes you any issues.

@carlosantoniodasilva
Copy link
Member

I'm reverting the merged change, as it caused a regression. See #1824 for more info.

Happy to review something else that fixes the original problem without the regression, but for now we'll have to live with it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants