Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

HIP128: Feedback/editorial change #1052

Merged
merged 18 commits into from
Jul 9, 2024
Merged

Conversation

Leitet
Copy link
Contributor

@Leitet Leitet commented Jul 8, 2024

This PR makes editorial changes:

1. Reduce emphasis on IoT network usage

Discussions showed that we might have overestimated the use of IoT network in the hip leading many to think that the IoT network will be used more than it is. This commit tones this down a bit by removing words like “substantial” and “significant”.

As of discussion:
https://discord.com/channels/404106811252408320/1257917899319017553/1259214601590014154

2. Standardize capitalization for ENERGY vs ENERGY Subnetwork

After discussion with community and HF we follow this capitalization of Energy/ENERGY:

ENERGY network or Energy network -> ENERGY Subnetwork

As of discussion:
https://discord.com/channels/404106811252408320/1257917899319017553/1258734498686697503
and follow up discussion with HF

3. veENERGY Staking changed to veHNT Delegation

HNT is staked to receive veHNT and then delegated to the Energy subnetwork. ENERGY is not staked to veENERGY.

As of discussion:
https://discord.com/channels/404106811252408320/1257917899319017553/1257964116518109226

4. Formatting of table and linting

Linting and formatting fixed.

5. Clarify DER Host staking

"Stakes ENERGY to qualify DERs for data and VPP service usage"

changed to

"Stakes ENERGY to qualify DERs for additional data and VPP service usage"

@@ -95,15 +96,14 @@ We propose using one pool for buffering issued baseline rewards:

**Network growth pool** acts as a resource for growing the network using direct incentives to DER hosts. This pool will receive tokens from the baseline DER host rewards inversely proportional to the total Energy subnetwork DC burn as long as this is less than $100 000 USD. The proportion allocated to the pool is calculated by:

Network Growth Pool Proportion = 0.5 − min(0.5, 0.5 * Total Energy Subnetwork DC burn / 1e10)
Network Growth Pool Proportion = 0.5 − min(0.5, 0.5 \* Total Energy Subnetwork DC burn / 1e10)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Perhaps we can do this in LaTeX to clean up the syntax.


$\text{Network Growth Pool Proportion}= 0.5 - \min\left(0.5, 0.5 \times \frac{\text{Total Energy Subnetwork DC burn}}{1e10}\right)$

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

$\text{Network Growth Pool Proportion} = 0.5 - \min\left(0.5, 0.5 \times \frac{\text{Total Energy Subnetwork DC burn}}{1e10}\right)$


Network Growth Pool Proportion = 0.5 − min(0.5, 0.5 * Total ENERGY Network DC burn / 1e10)
Network Growth Pool Proportion = 0.5 − min(0.5, 0.5 \* Total ENERGY Subnetwork DC burn / 1e10)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it would be cleaner to use LaTeX formatting here.

Suggested change
Network Growth Pool Proportion = 0.5 − min(0.5, 0.5 \* Total ENERGY Subnetwork DC burn / 1e10)
$\text{Network Growth Pool Proportion} = 0.5 - \min\left(0.5, 0.5 \times \frac{\text{Total Energy Subnetwork DC burn}}{10000000000}\right)$

$\text{Network Growth Pool Proportion} = 0.5 - \min\left(0.5, 0.5 \times \frac{\text{Total Energy Subnetwork DC burn}}{10000000000}\right)$

frahlg and others added 2 commits July 8, 2024 18:16
@Leitet
Copy link
Contributor Author

Leitet commented Jul 9, 2024

Updated description to match commits. Added one commit. See description 5.

0128-energy-subnetwork.md Outdated Show resolved Hide resolved
0128-energy-subnetwork.md Outdated Show resolved Hide resolved
0128-energy-subnetwork.md Outdated Show resolved Hide resolved
0128-energy-subnetwork.md Outdated Show resolved Hide resolved
0128-energy-subnetwork.md Outdated Show resolved Hide resolved
0128-energy-subnetwork.md Outdated Show resolved Hide resolved
0128-energy-subnetwork.md Outdated Show resolved Hide resolved
0128-energy-subnetwork.md Outdated Show resolved Hide resolved
frahlg and others added 8 commits July 9, 2024 14:46
Co-authored-by: Abhay Kumar <75+abhay@users.noreply.github.com>
Co-authored-by: Abhay Kumar <75+abhay@users.noreply.github.com>
Co-authored-by: Abhay Kumar <75+abhay@users.noreply.github.com>
Co-authored-by: Abhay Kumar <75+abhay@users.noreply.github.com>
Co-authored-by: Abhay Kumar <75+abhay@users.noreply.github.com>
Co-authored-by: Abhay Kumar <75+abhay@users.noreply.github.com>
Co-authored-by: Abhay Kumar <75+abhay@users.noreply.github.com>
Co-authored-by: Abhay Kumar <75+abhay@users.noreply.github.com>
@hiptron hiptron merged commit 85885c3 into helium:main Jul 9, 2024
@frahlg frahlg deleted the feedback/editorial branch July 9, 2024 21:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants