feat: refactor smart transaction sender & confirmation #114
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…onfirmTransaction params
0xIchigo
requested changes
Jul 29, 2024
|
Awesome. I'm currently away on a trip, so I will fix everything when I get back. |
0xIchigo
requested changes
Aug 13, 2024
|
Also, for future PRs, can you please make a separate branch instead of pushing from |
0xIchigo
approved these changes
Aug 13, 2024
|
I'm going to go ahead and merge — I'll take out the unused import myself. Thank you for your contribution! |
Sure, will do that next time! Do you think we can get this released soon? |
|
Yes, we'll cut a new release soon to include all of the recent PRs. I have a few more things I need to implement and get reviewed, but I'll make sure it happens as fast as possible 🫡 |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is the continuation of #97.
The new confirmation strategy uses the
confirmTransaction, with the possibility of adding an offset to thelastValidBlockHeightoption. The reason for that is to address scenarios where the transaction is included after thelastValidBlockHeightdue to network latency or due to the leader not forwarding the transaction for an unknown reason.Trade-off: better reliability at the cost of possible longer confirmation times.
Addresses #112