change to check if readonly on set_path()

helix-term/src/ui/statusline.rs

@@ -432,8 +432,8 @@ fn render_file_modification_indicator<F>(context: &mut RenderContext, write: F)
 where
     F: Fn(&mut RenderContext, String, Option<Style>) + Copy,
 {
-    debug_assert!(!(context.doc.is_read_only() && context.doc.is_modified()));
-    let title = (if context.doc.is_read_only() {
+    debug_assert!(!(context.doc.readonly.unwrap_or(false) && context.doc.is_modified()));
+    let title = (if context.doc.readonly.unwrap_or(false) {
         "[readonly]"
     } else if context.doc.is_modified() {
         "[+]"

helix-view/src/document.rs

@@ -185,6 +185,9 @@ pub struct Document {
 
     // when document was used for most-recent-used buffer picker
     pub focused_at: std::time::Instant,
+
+    // logically true when equal to Some(true); None implies we haven't checked yet
+    pub readonly: Option<bool>,
 }
 
 /// Inlay hints for a single `(Document, View)` combo.
@@ -673,6 +676,7 @@ impl Document {
             config,
             version_control_head: None,
             focused_at: std::time::Instant::now(),
+            readonly: None
         }
     }
 
@@ -1018,6 +1022,15 @@ impl Document {
         // and error out when document is saved
         self.path = path;
 
+        // Check if the file is readonly or not
+        self.readonly = Some(match &self.path {
+            None => false,
+            Some(p) => match std::fs::metadata(p) {
+                Err(_) => false,
+                Ok(metadata) => metadata.permissions().readonly(),
+            },
+        });
+
         Ok(())
     }
 
@@ -1416,16 +1429,6 @@ impl Document {
         self.id
     }
 
-    pub fn is_read_only(&self) -> bool {
-        match &self.path {
-            None => false,
-            Some(p) => match std::fs::metadata(p) {
-                Err(_) => false,
-                Ok(metadata) => metadata.permissions().readonly(),
-            },
-        }
-    }
-
     /// If there are unsaved modifications.
     pub fn is_modified(&self) -> bool {
         let history = self.history.take();