Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The Prompt should use a bar cursor if the user has configured Insert mode to use a bar cursor #10874

Closed
frou opened this issue Jun 3, 2024 · 1 comment · Fixed by #10945
Closed
Labels
A-helix-term Area: Helix term improvements C-enhancement Category: Improvements

Comments

@frou
Copy link

frou commented Jun 3, 2024

The configuration:

[editor.cursor-shape]
insert = "bar"

...is basically indicating that we want a bar cursor when writing text:

Screenshot 2024-06-03 at 15 57 47

Since writing text is what happens in the prompt, it should respect that setting rather than forcibly using a block cursor:

Screenshot 2024-06-03 at 15 55 01
@frou frou added the C-enhancement Category: Improvements label Jun 3, 2024
@kirawi kirawi added the A-helix-term Area: Helix term improvements label Jun 11, 2024
GNUSheep added a commit to GNUSheep/helix that referenced this issue Jun 13, 2024
@the-mikedavis the-mikedavis linked a pull request Jun 14, 2024 that will close this issue
pascalkuthe pushed a commit that referenced this issue Jun 18, 2024
@frou
Copy link
Author

frou commented Jun 18, 2024

Thank you @GNUSheep for implementing this. Looks like a nice straightforward diff!

smortime pushed a commit to smortime/helix that referenced this issue Jul 10, 2024
mxxntype pushed a commit to mxxntype/helix that referenced this issue Aug 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-helix-term Area: Helix term improvements C-enhancement Category: Improvements
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants