Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

No longer possible to filter global search results by file name #11212

Closed
xJonathanLEI opened this issue Jul 17, 2024 · 3 comments
Closed

No longer possible to filter global search results by file name #11212

xJonathanLEI opened this issue Jul 17, 2024 · 3 comments
Labels
C-bug Category: This is a bug

Comments

@xJonathanLEI
Copy link
Contributor

Summary

The old global search command used to ask you for the pattern in the prompt, with the picker itself used for filtering files by name. Again submitting as bug as this used to be possible. Please feel free to change the label if appropriate.

This was very useful. Consider a use case like changing a dependency version like for serde. You have numerous references to serde throughout the project, whereas most of them are irrelevant. It used to be the case that you can search and simply filter by Cargo.toml and work on those. This is now no longer doable. (For this specific case you can instead search for serde = but that relies on proper formatting so it's not ideal)

I don't have a good solution here until we have multiple inputs on pickers. Can we... (requesting once again)... just bring back the old global search on the side?

Reproduction Steps

Do a global search and realize you cannot filter by file name anymore.

Helix log

N/A

Platform

Any really

Terminal Emulator

Any really

Installation Method

Any really

Helix Version

helix 24.7 (c9d829a)

@xJonathanLEI xJonathanLEI added the C-bug Category: This is a bug label Jul 17, 2024
@kirawi
Copy link
Member

kirawi commented Jul 17, 2024

You need to do %p PATH in the prompt IIRC. You can enclose the queries in quotes if you want to do multiple filters.

@xJonathanLEI
Copy link
Contributor Author

You need to do %p PATH in the prompt IIRC. You can enclose the queries in quotes if you want to do multiple filters.

Oh but then the issue becomes that any trailing whitespaces are now ignored for this to work. There are legit use cases when you'd search with trailing spaces though?

@the-mikedavis
Copy link
Member

You can use [ ] or \s and the end of the search query for that

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
C-bug Category: This is a bug
Projects
None yet
Development

No branches or pull requests

3 participants