Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Global search path filter becoming part of the search history #11214

Closed
xJonathanLEI opened this issue Jul 17, 2024 · 1 comment · Fixed by #11216
Closed

Global search path filter becoming part of the search history #11214

xJonathanLEI opened this issue Jul 17, 2024 · 1 comment · Fixed by #11216
Labels
C-bug Category: This is a bug

Comments

@xJonathanLEI
Copy link
Contributor

Summary

With the patch in #11209, now the search history is updated as expected following choosing an entry.

However, as a side effect together with #11212, now doing the search with a path filter means the %p xxx part gets spilled into search history too. So the workflow of "searching for something globally then proceeding to do it locally via n" stops working.

Maybe we should extract the "raw query" part and only add that instead? WDYT?

Reproduction Steps

N/A

Helix log

N/A

Platform

Any really

Terminal Emulator

Any really

Installation Method

Any really

Helix Version

helix 24.7 (c9d829a)

@xJonathanLEI xJonathanLEI added the C-bug Category: This is a bug label Jul 17, 2024
@the-mikedavis
Copy link
Member

Ah yeah, we need to insert the Picker::primary_query rather than the whole line

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
C-bug Category: This is a bug
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants