Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Select_register command should provide visual feedback #1585

Closed
eugenesvk opened this issue Jan 27, 2022 · 2 comments · Fixed by #7222
Closed

Select_register command should provide visual feedback #1585

eugenesvk opened this issue Jan 27, 2022 · 2 comments · Fixed by #7222
Labels
A-helix-term Area: Helix term improvements C-enhancement Category: Improvements

Comments

@eugenesvk
Copy link

select_register command should provide visual feedback (e.g., via a status bar message) after a register is selected
For example, executing select_register then pressing 5 should print "register 5 is selected" or something

@eugenesvk eugenesvk added the C-enhancement Category: Improvements label Jan 27, 2022
@archseer
Copy link
Member

We do print count & pending keys in the bottom right (i.e. 33 before pressing g will show up) but looks like we don't do that yet for the register (printing "@ for example)

for key in self.keymaps.pending() {
let s = key.to_string();
if s.graphemes(true).count() > 1 {
disp.push_str(&format!("<{}>", s));
} else {
disp.push_str(&s);
}
}

There's also #980 that will make register selection a bit nicer.

@archseer
Copy link
Member

archseer commented Jan 27, 2022

(Prior art, kakoune renders this as reg=@ on the statusline, whereas pending keys render as param=33)

@kirawi kirawi added the A-helix-term Area: Helix term improvements label Jan 27, 2022
spectre256 added a commit to spectre256/helix that referenced this issue Jun 3, 2023
Resolves issue helix-editor#1585 by adding a status message when a register is
selected, similar to the message produced when recording a macro.
Additionally, an indicator appears on the right.
spectre256 added a commit to spectre256/helix that referenced this issue Jun 8, 2023
Resolves issue helix-editor#1585 by adding a new statusline component which indicates
the currently selected register.
spectre256 added a commit to spectre256/helix that referenced this issue Jun 8, 2023
Resolves issue helix-editor#1585 by adding a new statusline component which indicates
the currently selected register.
@the-mikedavis the-mikedavis linked a pull request Jun 8, 2023 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-helix-term Area: Helix term improvements C-enhancement Category: Improvements
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants