<A-Enter> in the file picker jumps to a line in the current file instead of a new one

[woojiq]

Summary

Bug was introduced by #4435
Demo: https://asciinema.org/a/yQdXysBaY8nBwoBSoam92efq7
I press gr (goto reference) two times.
As you can see, when I first open with <Enter>, it immediately shows me a line with the selected goto reference. The second time I press Alt-Enter, it opens but the cursor of the new file is on 1 line and the line of my current file is scrambled.

Also, whoever is going to fix this, I would like to see these key bindings somewhere in the documentation, as the only mention of it is the code in PR.

Reproduction Steps

1. hx helix-term/src/commands + g400g.
2. gr + select second entry + <Alt-Enter>.

You will see that your cursor on the current file is on line 166. But it should actually open a new file on that line.

Helix log

~/.cache/helix/helix.log

Platform

Linux

Terminal Emulator

wezterm 20230712-072601-f4abf8fd

Helix Version

helix 23.05-230-g79a8fd62

[pascalkuthe]

I don't understnd the issue here, what do you mean with opening a new file. <alt>ret doesn't open a split. It just does the same thing as enter without closing the picker. In my testing that is exactly what it does

[woojiq]

@pascalkuthe have you tried <alt>ret with the default filepicker <space>f or a picker where the line number is appended to the filename (eg gr goto reference)?

[pascalkuthe]

I tried with gr

[woojiq]

example

1. I open the main.rs file.
2. gr for a function and see lib.rs:130 in the picker. Before I open it, my main file is on line 20 (for example).
3. I press alt-enter to open lib.rs in a new buffer in the background.
4. I close the picker and the main.rs buffer gets focus as expected, but now the current line is 130 (expected 20)
5. I go to the next buffer (lib.rs) and it focused on line 1 (expected 130).

Do you understand my problem?

[pascalkuthe]

Hmm yeah thanks for clarifying I will try to reproduce again, I think I missunderstood your original description. I think I know what causes this. We are probably first loading the file and then changing the position in the current buffer. Implementing this might be a bit tricky since changing lines in an inactive buffer is usually not something we do

[woojiq]

This patch fixes issue. Is it good enough for PR or should we come up with something better?

[pascalkuthe]

That probably works, you can post a PR and we can take a closer look during review. I was thinking of something else regarding complexity its probably ok like that