file picker freezes on big binary files

[adsick]

so when I am in my Downloads folder and use my Up and Down arrows to navigate the menu I experience full freeze when something like Linux distribution 1.9Gb iso image is selected.

one thing it does not even need to preview these types of files, the second: preview is implemented in a wrong way so it (supposedly) tries to read the file entirely when only the first "page" is enough.

[adsick]

also I don't quite understand why file picker works the way it does - I would expect it to list only current working dir files, but it lists every imaginable file on my desktop.

[Omnikar]

also I don't quite understand why file picker works the way it does - I would expect it to list only current working dir files, but it lists every imaginable file on my desktop.

What displays when you :pwd?

[adsick]

ah, it displays me my home dir, but why it does so if I've opened helix with hx rust/temp/iter-test

[kirawi]

This is likely related to #338

Edit: Never mind, I misread.

[kirawi]

Hmm, are you using 0.4.1? If so, can you try to build from master to see if it works?

[Omnikar]

ah, it displays me my home dir, but why it does so if I've opened helix with hx rust/temp/iter-test

If you start helix with a directory as the argument, it will use that directory. Otherwise, it will use the directory your shell is currently in.

[adsick]

If you start helix with a directory as the argument, it will use that directory.

I don't understand, I mentioned the directory, but helix remained in the current one (home)

[Omnikar]

I don't understand, I mentioned the directory, but helix remained in the current one (home)

Oh, I see. I imagine it should work like that, but apparently it doesn't. I guess I can try and fix that and open a PR.

#849

[archseer]

We should skip rendering both binary files and files over a certain limit (10-20MB)

[archseer]

Fixed by #939