Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
accept count for goto_window #1033
accept count for goto_window #1033
Changes from 3 commits
02408a3
26ce99a
9686b5e
93e8774
a58eb04
8960c70
e19575c
cc393df
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think it would better to follow the vim behavior here of having count starting from scrolloff point, otherwise
1gt
would result in moving the screen by scrolloff.But vim behavior here is good I think. If the screen is at the corner of the screen (0 or file end),
1H
will go to the first line without scrolloff (same for the end), and if the screen is being scrolled to the middle,1H
will go to the first scrolloff position rather than the top. This is the nicer behavior but I think it is a bit more complicated to implement.And with large scrolloff count it doesn't move the screen, so
<n>H
in vim won't change the screen in any bits, it will move to the last scrolloff point.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
done, please take a another look