Improve LSP workspace/applyEdit by keeping the editor from switching to normal mode when loading a Document #11176
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
archseer
approved these changes
Jul 15, 2024
pascalkuthe
approved these changes
Jul 15, 2024
mxxntype
pushed a commit
to mxxntype/helix
that referenced
this pull request
Aug 14, 2024
kyruzic
pushed a commit
to kyruzic/helix
that referenced
this pull request
Sep 27, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When an existing Document is opened with
Editor::open(path, Action::Load), this causesEditor::switchto be called.This in turn resets the mode of the editor to normal mode, even if the loaded Document is not even in the current buffer.
To my knowledge this is only an issue in combination with the LSP
workspace/applyEditfunctionality.Language servers that heavily utilize
applyEditmake using helix nearly impossible, as typing and selecting is constantly interrupted by unexpected mode changes.