goto_file: Try multiple relative paths (including cwd) to find existing files
#11859
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
inducer
commented
Oct 9, 2024
| if cwd.exists() { | ||
| search_paths.push(cwd); | ||
| } | ||
| // FIXME: Also include project root? Or just use project root, not cwd? |
There was a problem hiding this comment.
I could not quickly figure out how to find the LSP root for the document, but if available, this may be a better (or at least a valid additional) choice.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I am editing files that contain paths of other files. Those paths are relative to the repository root, not the path in which the document resides. Therefore, the current implementation of
gf/goto_filedoes the wrong thing for me, namely interpret those paths as relative to the latter. This change makes helix look for files with the given name relative to multiple locations: the directory containing the document, and the editor's current working directory. I approached this change in this way to avoid changing the behavior for folks for whom the current semantics work fine.My rust skill is basically non-existent, so I am glad that I was able to cobble something together that seems to work for me. Feedback is very welcome though.