Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for textproto language. #11874

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

sdoerner
Copy link

Copy link
Member

@the-mikedavis the-mikedavis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The changes here look good but https://github.com/PorterAtGoogle/tree-sitter-textproto doesn't have a license file yet. Could you suggest adding one upstream and update the revision in languages.toml when upstream adds one?

@the-mikedavis the-mikedavis added the A-language-support Area: Support for programming/text languages label Oct 16, 2024
@sdoerner
Copy link
Author

FWIW, it does mention ISC in package.json, but I'm happy to make the suggestion to add the file.

@sdoerner
Copy link
Author

The changes here look good but https://github.com/PorterAtGoogle/tree-sitter-textproto doesn't have a license file yet. Could you suggest adding one upstream and update the revision in languages.toml when upstream adds one?

Done.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-language-support Area: Support for programming/text languages
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants