ignore Enter keypress when menu has no selection #1704
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
supersedes helix-editor#1622 Builds on the work in helix-editor#1285. I want to allow Enter to create a newline when there is no selection in the autocomplete menu. This occurs somewhat often when using LSP autocomplete in Elixir which uses `do/end` blocks (and I set the autocomplete menu delay to 0 which exacerbates the problem): ```elixir defmodule MyModule do def do_foo(x) do x end def other_function(y) do| end ``` Here the cursor is `|` in insert mode. The LSP suggests `do_foo` but I want to create a newline. Hitting Enter currently closes the menu, so I end up having to hit Enter twice when the module contains any local with a `do` prefix, which can be inconsistent. With this change, we ignore the Enter keypress to end up creating the newline in this case.
archseer
reviewed
Feb 25, 2022
archseer
reviewed
Feb 25, 2022
the-mikedavis
force-pushed
the
md-ignore-enter-event-in-menu-on-no-selection
branch
from
03112b4
to
038aaa1
Compare
|
I ran into some type and life-cycle stuff I don't really understand yet. I'll do some reading and swing back around to this PR when I understand more 👍 |
archseer
reviewed
Feb 26, 2022
archseer
approved these changes
Feb 27, 2022
the-mikedavis
deleted the
md-ignore-enter-event-in-menu-on-no-selection
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
supersedes #1622
Uses the new
EventResultmember introduced in #1285. I want to allowEnter to create a newline when there is no selection in the autocomplete menu.
This occurs somewhat often when using LSP autocomplete in Elixir which
uses
do/endblocks (and I set the autocomplete menu delay to 0 whichexacerbates the problem):
Here the cursor is
|in insert mode. The LSP suggestsdo_foobut Iwant to create a newline. Hitting Enter currently closes the menu,
so I end up having to hit Enter twice when the module contains any
local with a
doprefix, which can be inconsistent. With this change,we ignore the Enter keypress to end up creating the newline in this case.