Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement EditorConfig support #1777

Open
wants to merge 24 commits into
base: master
Choose a base branch
from
Open

Implement EditorConfig support #1777

wants to merge 24 commits into from

Commits on Mar 8, 2022

  1. Add initial editorconfig parsing on document open 

    Currently disabled, see the use of Document::open_with_editorconfig in editor.rs.
More fields in Document will be needed for some of the properties.
Currently, in theory, only line ending, indent style, and encoding are supported.
    @TheDaemoness
    TheDaemoness committed Mar 8, 2022
    Configuration menu
    Copy the full SHA
    aa65111 View commit details
    Browse the repository at this point in the history

Commits on Mar 10, 2022

  1. Add document::Config and parse editorconfig into it

    @TheDaemoness
    TheDaemoness committed Mar 10, 2022
    Configuration menu
    Copy the full SHA
    0d433fd View commit details
    Browse the repository at this point in the history

  2. Add a flag to enable EditorConfig support

    @TheDaemoness
    TheDaemoness committed Mar 10, 2022
    Configuration menu
    Copy the full SHA
    a9ee261 View commit details
    Browse the repository at this point in the history

  3. Fix Config-related clippy lints

    @TheDaemoness
    TheDaemoness committed Mar 10, 2022
    Configuration menu
    Copy the full SHA
    6950865 View commit details
    Browse the repository at this point in the history

Commits on Jun 11, 2022

  1. Merge branch 'master' of https://github.com/helix-editor/helix into h… 

    …elix-editor-master
    @TheDaemoness
    TheDaemoness committed Jun 11, 2022
    Configuration menu
    Copy the full SHA
    c120e35 View commit details
    Browse the repository at this point in the history

  2. Merge upstream changes

    @TheDaemoness
    TheDaemoness committed Jun 11, 2022
    Configuration menu
    Copy the full SHA
    86c0923 View commit details
    Browse the repository at this point in the history

  3. Bump ec4rs to 1.0.0 and apply fixes

    @TheDaemoness
    TheDaemoness committed Jun 11, 2022
    Configuration menu
    Copy the full SHA
    278d9f4 View commit details
    Browse the repository at this point in the history

Commits on Jun 25, 2022

  1. Merge branch 'helix-editor:master' into master

    @TheDaemoness
    TheDaemoness authored Jun 25, 2022
    Configuration menu
    Copy the full SHA
    73a8f25 View commit details
    Browse the repository at this point in the history

  2. Update ec4rs

    @TheDaemoness
    TheDaemoness committed Jun 25, 2022
    Configuration menu
    Copy the full SHA
    2bff8f2 View commit details
    Browse the repository at this point in the history

  3. Add support for EditorConfig tab_width

    @TheDaemoness
    TheDaemoness committed Jun 25, 2022
    Configuration menu
    Copy the full SHA
    0ec192a View commit details
    Browse the repository at this point in the history

  4. Make Document::tab_width_override private

    @TheDaemoness
    TheDaemoness committed Jun 25, 2022
    Configuration menu
    Copy the full SHA
    ff3d631 View commit details
    Browse the repository at this point in the history

  5. Update ec4rs version requirement 

    ec4rs 1.0.0 requires a later version of Rust than Helix is made for at this time.
ec4rs 1.0.1 (and later versions in the 1.0.x series) do not.
The version requirement has been updated to reflect this.
    @TheDaemoness
    TheDaemoness committed Jun 25, 2022
    Configuration menu
    Copy the full SHA
    d07440d View commit details
    Browse the repository at this point in the history

Commits on Jul 14, 2022

  1. Merge branch 'helix-editor:master' into master

    @TheDaemoness
    TheDaemoness authored Jul 14, 2022
    Configuration menu
    Copy the full SHA
    e177b85 View commit details
    Browse the repository at this point in the history

  2. Remove unused method in helix_view::document::Config

    @TheDaemoness
    TheDaemoness committed Jul 14, 2022
    Configuration menu
    Copy the full SHA
    c878e20 View commit details
    Browse the repository at this point in the history

Commits on Aug 7, 2022

  1. Rename document::Config to DocumentOptions

    @TheDaemoness
    TheDaemoness committed Aug 7, 2022
    Configuration menu
    Copy the full SHA
    2d8fefa View commit details
    Browse the repository at this point in the history

  2. Change document tab width field

    @TheDaemoness
    TheDaemoness committed Aug 7, 2022
    Configuration menu
    Copy the full SHA
    7f57658 View commit details
    Browse the repository at this point in the history

  3. Merge branch 'master' of https://github.com/helix-editor/helix

    @TheDaemoness
    TheDaemoness committed Aug 7, 2022
    Configuration menu
    Copy the full SHA
    77dffd7 View commit details
    Browse the repository at this point in the history

  4. Fix incomplete documentation of DocumentOptions

    @TheDaemoness
    TheDaemoness committed Aug 7, 2022
    Configuration menu
    Copy the full SHA
    7de1bbe View commit details
    Browse the repository at this point in the history

Commits on Mar 18, 2023

  1. Merge from upstream, discard EditorConfig-related changes

    @TheDaemoness
    TheDaemoness committed Mar 18, 2023
    Configuration menu
    Copy the full SHA
    5d53965 View commit details
    Browse the repository at this point in the history

  2. Re-implement EditorConfig integration

    @TheDaemoness
    TheDaemoness committed Mar 18, 2023
    Configuration menu
    Copy the full SHA
    ff215a8 View commit details
    Browse the repository at this point in the history

  3. Make ConfigureDocument and DocumentConfig private 

    Currently Document::open_with_cfg is private,
which is the only place they're used.
    @TheDaemoness
    TheDaemoness committed Mar 18, 2023
    Configuration menu
    Copy the full SHA
    91af0f1 View commit details
    Browse the repository at this point in the history

Commits on Mar 31, 2023

  1. Merge branch 'master' into master

    @TheDaemoness
    TheDaemoness authored Mar 31, 2023
    Configuration menu
    Copy the full SHA
    a4f9325 View commit details
    Browse the repository at this point in the history

  2. Fixup documentation and indent size handling

    @TheDaemoness
    TheDaemoness committed Mar 31, 2023
    Configuration menu
    Copy the full SHA
    6fbc8af View commit details
    Browse the repository at this point in the history

Commits on Apr 1, 2023

  1. Remove DocumentConfig 

    This was a fairly unintuitive type whose functionality could be
replicated by adding some associated functions to
ConfigureDocument (which this commit also does).
    @TheDaemoness
    TheDaemoness committed Apr 1, 2023
    Configuration menu
    Copy the full SHA
    a359bec View commit details
    Browse the repository at this point in the history