Assistance on transition to termwiz #1847
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This also switches us to the use of the alterate screen, in order to reproduce the behaviour of removing the editor's output from the screen on exit that we had in crossterm. Not sure if there are undesirable downstream effects of that though.
pickfire
reviewed
Mar 21, 2022
Comment on lines
+252
to
+261
| pub fn claim_term(&mut self) -> Result<(), termwiz::Error> { | ||
| self.terminal.terminal().enter_alternate_screen()?; | ||
| self.terminal.terminal().set_raw_mode() | ||
| } | ||
|
|
||
| pub(crate) fn clear(&mut self) -> Result<(), termwiz::Error> { | ||
| let inner_term = self.terminal.terminal(); | ||
| inner_term.exit_alternate_screen()?; | ||
| inner_term.set_cooked_mode() | ||
| } |
There was a problem hiding this comment.
I think it's kinda confusing that one is called claim_term and the other clear.
There was a problem hiding this comment.
It should be claim_term and restore_term
There was a problem hiding this comment.
The cursor methods should be similarly renamed from save_cursor/load_cursor
the-mikedavis
added
the
S-waiting-on-author
kirawi
added
S-inactive
|
I had bitten off more than I could chew, and found myself in a leadership position at work to boot, lowering my availability. Closing this for someone else to take on some day, or perhaps some crossterm work upstream as many of the reasons for this have since disappeared through other implementations (eg bracketed paste). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is intended as a working branch to share work towards replacing crossterm with termwiz.
I began with replacing the terminal claiming and restoring with termwiz' equivalent logic. Since termwiz keeps those mehtods on the terminal instance, I had to move the logic into the Compositor to get access. However, the panic handler is a bit tricky as I can't reach inside the compositor from within there, and since Termwiz puts the methods on the struct, I'm not really sure how to acheive the same result.