Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(languages): SQL #2097

Merged
merged 3 commits into from
Apr 14, 2022
Merged

feat(languages): SQL #2097

merged 3 commits into from
Apr 14, 2022

Conversation

jaredramirez
Copy link
Contributor

Finally got around to adding sql language support. The original PR is here: #1464, but enough has changed since then (no submodules!) that I decided to just create a new branch & PR.

Only thing I'm not sure of is why when I built with nix, flake.lock changed so much.

@the-mikedavis
Copy link
Member

Oh hmm the flake lock change might be from an old nix version I would guess. Which version of the nix binary are you running?

@the-mikedavis the-mikedavis self-requested a review April 13, 2022 17:09
@jaredramirez
Copy link
Contributor Author

I'm on nix (Nix) 2.6.0pre20211217_6e6e998

@the-mikedavis
Copy link
Member

I think it might be that the flake follows change (NixOS/nix#6036) that showed up in 2.7.0 makes it so the lock is generated differently than older nix versions. The current flake is generated with 2.7.0. In any case, would you mind dropping it out of this PR since it's unrelated to the SQL change? We can merge it in later if it's reproducible on 2.7.0. I'll clear my store and try again in a bit to see if I can't reproduce it because of what I have cached locally.

@jaredramirez
Copy link
Contributor Author

Done!

Copy link
Member

@the-mikedavis the-mikedavis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks!

@the-mikedavis the-mikedavis changed the title feat(languages): Sql feat(languages): SQL Apr 14, 2022
@the-mikedavis the-mikedavis merged commit 460e6a8 into helix-editor:master Apr 14, 2022
adaliaramon pushed a commit to adaliaramon/helix-vim that referenced this pull request Apr 19, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants