Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix base16_terminal theme using incorrect ansi-color #2279

Merged
merged 1 commit into from
Apr 26, 2022

Conversation

ptomasroos
Copy link
Contributor

@ptomasroos ptomasroos commented Apr 26, 2022

The usage of light-white doesn't exist and its causing the base16_terminal to have a non existing cursor, also yielding an error in the error log.

Helix uses the notion of naming light-gray rather than light-white.

No visible cursor in theme
Screenshot 2022-04-26 at 08 40 40_no_cursor_visible

Visible cursor after using the correct color
Screenshot 2022-04-26 at 08 40 23_visible_cursor_again

@ptomasroos ptomasroos changed the title Fix base16_terminal theme Fix base16_terminal theme using incorrect ansi-color Apr 26, 2022
@the-mikedavis the-mikedavis linked an issue Apr 26, 2022 that may be closed by this pull request
Copy link
Member

@the-mikedavis the-mikedavis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice find! Thanks!

@the-mikedavis the-mikedavis merged commit fcd0ca3 into helix-editor:master Apr 26, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Block Cursor Disappear in base16_terminal
2 participants