Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Prevent panic when handling an LSP response with no request #2475

Merged
merged 1 commit into from
May 17, 2022
Merged

Prevent panic when handling an LSP response with no request #2475

merged 1 commit into from
May 17, 2022

Commits on May 16, 2022

  1. prevent panic when handling an LSP response with no request 

    A language server may push a response which doesn't belong to any
request. With this change, we discard the response rather than
crashing.

In the case of helix-editor#2474, the language server sends an error message
with a null request ID which should not ever exist in the
`pending_requests` HashMap.

closes helix-editor#2474
    @the-mikedavis
    the-mikedavis committed May 16, 2022
    Configuration menu
    Copy the full SHA
    4bb33e1 View commit details
    Browse the repository at this point in the history