Impelement reload-all command #2476
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
archseer
reviewed
May 15, 2022
| ) -> anyhow::Result<()> { | ||
| for doc in cx.editor.documents_mut() { | ||
| doc.selections().keys().for_each(|view_id| { | ||
| doc.reload(*view_id); |
There was a problem hiding this comment.
You shouldn't be calling reload() multiple times since it'll reload the file from disk on each call. Instead reload should be called with a single view (pick one at random)
There was a problem hiding this comment.
The reload method seems to be updating selections belonging to that view as well as history, does that not matter? I thought about refactoring the internal methods (apply, etc) to be view agnostic, but maybe they should loop through all views instead of doing it here?
the-mikedavis
added
the
S-waiting-on-author
kirawi
added
A-helix-term
|
Superceded by #4663 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a work in progress. I'm stuck fighting the borrow checker if someone can help.
Will close #2326