helix_view::theme [WARN] Theme #3119
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sudormrfbin
reviewed
Jul 21, 2022
runtime/themes/catppuccin.toml
Outdated
Comment on lines
95
to
97
| silver = "#c0c0c0" | ||
| apricot = "#f47868" | ||
| lightning = "#ffcd1c" |
There was a problem hiding this comment.
These three keys are from the default theme file, probably a remnant from being copied. The catppuccin style guide recommends using maroon for errors and peach for warnings (which is where these palette keys are used in this file). Something mild like lavender would be a good fit for the hint key too.
thomasskk
pushed a commit
to thomasskk/helix
that referenced
this pull request
Sep 9, 2022
* helix_view::theme [WARN] Theme * updated: warning, error, info, hint colours https://github.com/catppuccin/catppuccin/blob/main/docs/style-guide.md#typography Co-authored-by: Aiko Mastboom <git@aiko.sh>
thomasskk
pushed a commit
to thomasskk/helix
that referenced
this pull request
Sep 9, 2022
* helix_view::theme [WARN] Theme * updated: warning, error, info, hint colours https://github.com/catppuccin/catppuccin/blob/main/docs/style-guide.md#typography Co-authored-by: Aiko Mastboom <git@aiko.sh>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Quick attempt at removing some warnings from the log.
I have no theming knowledge, so unknown colors are probably off.