build(nix): add a way to override what grammars get built #3141
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
GreasySlug
pushed a commit
to GreasySlug/helix
that referenced
this pull request
Aug 2, 2022
thomasskk
pushed a commit
to thomasskk/helix
that referenced
this pull request
Sep 9, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds a way change which grammars get built and included by adding an
overridefunction to the helix package that takes anincludeGrammarIfattribute which is a function that decided whether the grammar should be included (true) or not (false). This also avoid fetching all of the grammars if you don't need them (like me) which speeds up fetching stuff when you are fetching when the sources aren't cached already. I also addedmakeWrapperArgsto theoverridefunction so it can be set there, I think @nrdxp asked about this.