Attempt to bring spacebones light up to speed with recent features #3342
Conversation
* Adds cursorline (primary and secondary) * Reworks colors slightly to try and match upstream theme better * Distinguishes primary from regular selections * Implements some of the markup specific styles * Implements mode colors support
| "ui.menu.selected" = { fg = "#655370", bg = "#d1dcdf", modifiers = ["bold"] } | ||
| "ui.virtual.whitespace" = "bg2" | ||
| "ui.menu.selected" = { fg = "base", bg = "bg2", modifiers = ["bold"] } | ||
| "ui.virtual" = "base-dim" |
There was a problem hiding this comment.
The ruler is a little faint. Should it be something like
"ui.virtual.ruler" = { bg = "base-dim" }so you can see it without having text cross it?
There was a problem hiding this comment.
I don't use the rulers feature, but trying it out I found base-dim to be too dark for my liking. I set it to bg1 which is the same color as the cursorline, which makes it almost look like a crosshairs type thing. Not sure if that's acceptable, I can change it agian.
|
There's also |
Yeah I didn't feel the need to distinguish those colors and lacked enough guidance on what the colors should be -- the upstream theme has a fairly limited palette. I could look at the full palette of the spacemacs theme as that seems to be ultimately where this came from, but I'm not sure I want to put in that time when I can work towards some tree-sitter stuff I've been sitting on a long time. |
The upstream doesn't have much in the way of guides, so I did my best. Not expecting everyone to agree on the color choices but those can be further adjusted before or after merge.