Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

lint: autumn #3565

Closed
wants to merge 2 commits into from
Closed

lint: autumn #3565

wants to merge 2 commits into from

Conversation

AlexanderBrevig
Copy link
Contributor

passes linter from #3234
image
image

@AlexanderBrevig
Copy link
Contributor Author

@getreu please sanity check my choices :)

getreu
getreu suggested changes Aug 28, 2022
View reviewed changes
Copy link
Contributor

@getreu getreu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I do not understand what your PR actually visually changes. Or, is it for completeness?
Anyway, shouldn't be both files changed the same way?

@AlexanderBrevig
Copy link
Contributor Author

I do not understand what your PR actually visually changes. Or, is it for completeness?
Anyway, shouldn't be both files changed the same way?

Cursorline is an upcoming feature, it's for completeness. The extra fg for the one theme is an oversight. I'll remove it later today 👍 thanks

@AlexanderBrevig
Copy link
Contributor Author

Moved to bulk PR #3587

@AlexanderBrevig
Copy link
Contributor Author

Moved to bulk PR #3587

@getreu
Copy link
Contributor

getreu commented Aug 28, 2022

Thank you for explaining. Changes are OK for me.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@getreu getreu getreu requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@AlexanderBrevig @getreu