Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

read only indicator #3709

Closed

Conversation

sbromberger
Copy link
Contributor

Rebased #2862.

@sbromberger
Copy link
Contributor Author

Do we want read-only indicators in bufferline as well? It's an easy add.

Comment on lines +402 to +410
// this seems overly complex but should make it easier
// to extend doc.file_stat with more information in the future.
doc.write_permission = fs::metadata(path).map_or(WritePermission::Unknown, |f| {
if f.permissions().readonly() {
WritePermission::ReadOnly
} else {
WritePermission::Writable
}
});
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should probably be part of doc.set_path since a path can also be changed after opening?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What are the implications of changing a path after opening?

@sbromberger sbromberger deleted the sbromberger/ro-indicator branch September 11, 2022 13:43
@goyalyashpal
Copy link
Contributor

Why did the author close this without any info?

@tjkirch
Copy link

tjkirch commented May 11, 2023

Does anyone know if there's work ongoing for a read-only indicator, or a read-only flag/option for buffers? I can't find any info about why this PR was closed or anything happening after it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants