Provide option to completely disable LSP #4425
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
I think this looks good - I would prefer an option like this to the change in #4391 (removing LSP config by deleting the toml keys). I think this just needs a new line in the book for the new option:
helix/book/src/configuration.md
Line 111 in 801984c
|
Done |
the-mikedavis
approved these changes
Oct 24, 2022
Merged
dead10ck
force-pushed
the
disable-lsp
branch
2 times, most recently
from
201eeb3
to
803a8cc
Compare
kirawi
added
A-helix-term
|
@archseer any thoughts? |
dead10ck
force-pushed
the
disable-lsp
branch
2 times, most recently
from
c3570f5
to
1f11593
Compare
dead10ck
force-pushed
the
disable-lsp
branch
3 times, most recently
from
54ed35d
to
033d3e2
Compare
dead10ck
force-pushed
the
disable-lsp
branch
from
033d3e2
to
a33b07e
Compare
dead10ck
force-pushed
the
disable-lsp
branch
from
a33b07e
to
7b66998
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I had had this code sitting around in a branch I'm working on already before #4391 became necessary in order to turn off LSP for the integration tests. It slows them down and is totally unnecessary until we figure out a good way to do integration tests with real language servers.
I'm making this PR as a proposed different way to approach this, where this is generalized into a user config option exposed to the user. I figure that while my motivation for this was reducing noise in the integration tests, this could conceivably be desirable by some users without having to e.g. compile out LSP integration with a feature flag.
Another benefit is that when we do get to integration tests around LSP, we won't need to manually specify a language config; we'll just need to set this one boolean config setting in the test invocation, which is a lot less tedious, and allows always testing the same default configs that ship to users.
With that said, I don't actually have any strong feelings about keeping this, I just thought it was worth proposing and seeing what everyone thinks since I had already done it. I'm perfectly content leaving it the way it is now.