Vertical Selection #462
Merged
Vertical Selection #462
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
archseer
requested changes
Jul 17, 2021
archseer
reviewed
Jul 18, 2021
helix-term/src/commands.rs
Outdated
| let mut ranges: SmallVec<_> = old_selection.ranges().into(); | ||
| for r in old_selection.iter() { | ||
| ranges.push(Range::point( | ||
| movement::move_vertically(text, *r, Direction::Backward, count, Movement::Extend).head, |
There was a problem hiding this comment.
Okay one last thing: The count should duplicate the selection on n lines, for example 3C should duplicate it on all three lines above the current line. move_vertically's count will instead give you a single range that's n lines above.
There was a problem hiding this comment.
Ah good point; I forgot about that...
archseer
force-pushed
the
vertical_selection
branch
2 times, most recently
from
ef6e500
to
995f25c
Compare
archseer
force-pushed
the
vertical_selection
branch
from
995f25c
to
7918db0
Compare
|
Ended up reworking this myself :) Thanks for the PR! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
My attempt to add #457.
This does not 'undo' a selection when moving into the opposite direction; instead it enlarges it. Not sure what the behaviour should be.