Select current file in file picker #4905
Conversation
mangas
changed the title
mangas
force-pushed
the
select-current-file-picker
branch
4 times, most recently
from
3c042b9
to
4785866
Compare
mangas
changed the title
kirawi
added
A-helix-term
mangas
force-pushed
the
select-current-file-picker
branch
3 times, most recently
from
90bc020
to
91a6331
Compare
mangas
force-pushed
the
select-current-file-picker
branch
3 times, most recently
from
42ff822
to
a6f87c3
Compare
mangas
force-pushed
the
select-current-file-picker
branch
from
a6f87c3
to
af6c68f
Compare
There was a problem hiding this comment.
One minor comment, but otherwise I think this looks reasonable. It is generic enough that it allows for picking a different default in the other pickers as well in the future, should that be desirable.
I considered whether the default item member of the Picker should be a closure, rather than a concrete value, but I think in all the contexts where pickers are made, they should be able to decide at the time of that picker's construction which actual concrete value to choose as the default.
I haven't tested this locally yet, but the code seems good.
| @@ -112,9 +112,11 @@ impl<T: Item> FilePicker<T> { | |||
| editor_data: T::Data, | |||
| callback_fn: impl Fn(&mut Context, &T, Action) + 'static, | |||
| preview_fn: impl Fn(&Editor, &T) -> Option<FileLocation> + 'static, | |||
| initial_cursor: Option<T>, | |||
There was a problem hiding this comment.
Should this be called initial_item instead?
|
closing this PR as stale. Ultimaetly I don't think this is the direction we would be going with the picker. Sorting is not possible anymore with a streaming picker and imo this usecase is better covered by Thank you for contributing! |
An attempt at implementing #3014