Fix autocompletion for paths with period #5175
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
the-mikedavis
added
C-bug
dead10ck
reviewed
Dec 22, 2022
helix-term/src/ui/mod.rs
Outdated
| Some(path) if !path.as_os_str().is_empty() => path.to_path_buf(), | ||
| // Path::new("h")'s parent is Some("")... | ||
| _ => std::env::current_dir().expect("couldn't determine current directory"), | ||
| let is_period = (input.ends_with("/.") && input.len() > 2) || input == "."; |
There was a problem hiding this comment.
Should this use std::path::MAIN_SEPARATOR instead of hardcoding /?
kirawi
pushed a commit
to kirawi/helix
that referenced
this pull request
Jan 25, 2023
* Bug fix Updated bug fix * Simplified conditionals * Switched to use path separator constant
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix for #5136
Bug has to do with how the
file_namemethod deals with paths ending in.or/.. I hardcoded the value forfile_namefor paths ending in/.and paths that only consist of a single period, and updated the logic forpath.