Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add scrolling down past the scroll-off height at the bottom of the buffer #5207

Closed
wants to merge 1 commit into from

Conversation

jrmoulton
Copy link
Contributor

When using scroll via page_down this lets the buffer go beyond just the distance set by scroll off. This is what I expected from vim and is useful because I often use page_down to position the screen to my liking including when I am at the bottom of the buffer. I've currently set this as a configuration feature that defaults to false

If this really should be a configuration feature how should it be named?

@the-mikedavis the-mikedavis linked an issue Dec 20, 2022 that may be closed by this pull request
@the-mikedavis
Copy link
Member

That line prevents page_downing further if the end of the document is visible which is different from the scrolloff. (last_line is the last visible line in the current viewport in this block.) Vim and Kakoune also respect scrolloff when using PageDown at the end of a document.

See #4590 (comment)

I don't think we need a config option for this behavior

@jrmoulton
Copy link
Contributor Author

Ahh I missed those. That makes sense. I'll go ahead and close this PR

@jrmoulton jrmoulton closed this Dec 20, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Allow C-u / C-d to travel to extents
2 participants