Fix language config reload logic #5381
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
the-mikedavis
approved these changes
Jan 3, 2023
|
Thanks! |
semin-park
pushed a commit
to semin-park/helix
that referenced
this pull request
Jan 4, 2023
semin-park
pushed a commit
to semin-park/helix
that referenced
this pull request
Jan 4, 2023
seewishnew
pushed a commit
to seewishnew/helix
that referenced
this pull request
Jan 6, 2023
freqmod
pushed a commit
to freqmod/helix
that referenced
this pull request
Feb 8, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #5377.
I think the bug #5377 stemmed from not updating the reference to the syntax loader in the
editoras well.Hence, it probably was the case that before, the old reference was in fact actually never dropped, and that the
editorwas still pointing to the old syntax loader.Took the chance to improve some status messages too.