-
-
Notifications
You must be signed in to change notification settings - Fork 2.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update tutor logo #5681
Update tutor logo #5681
Conversation
0e98dd8
to
5b5db9e
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this is cool!
runtime/tutor
Outdated
_ _ __ __ | ||
| | | | _ \ \ / / | ||
| |_| | ___ | | (_) \ \/ / | ||
| _ | / _ \ | | _ ) ( | ||
| | | | | __/ | | | | / /\ \ | ||
|_| |_| \___| |_| |_| /_/ \_\ | ||
|
||
A post-modern modal text editor. | ||
_________________________________________________________________ | ||
. | ||
###x. .| | ||
d#####x, ,v|| | ||
'+#####v|||||| | ||
,v|||||+'. _ _ _ | ||
,v|||||^'>#### | | | | ___ | | (_) __ __ | ||
|||||^' .v#### | |___| | / \ | | _ \ \/ / | ||
||||=..v#####P' | ___ | / ^ | | | | | \ / | ||
''v'>#####P' | | | | | --- | | | | / \ | ||
,######/P||x. |_| |_| \___/ |_| |_| /_/\_\ | ||
####P' "x|||||, | ||
|/' 'x||| A post-modern modal text editor. | ||
' '| | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The change in height in this section will make this first page of the tutor too tall: each section in the tutor has the same height.
I'm not sure how to save any height in this section though. Maybe we could split some of the text below the logo into a section "0 INTRODUCTION"?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Oh interesting I never noticed. Happy to do whatever folks think works. Here's a mockup of the top of the document with all pages the same height and the introduction put into an introduction section:
.
###x. .|
d#####x, ,v||
'+#####v||||||
,v|||||+'. _ _ _
,v|||||^'>#### | | | | ___ | | (_) __ __
|||||^' .v#### | |___| | / \ | | _ \ \/ /
||||=..v#####P' | ___ | / ^ | | | | | \ /
''v'>#####P' | | | | | --- | | | | / \
,######/P||x. |_| |_| \___/ |_| |_| /_/\_\
####P' "x|||||,
|/' 'x||| A post-modern modal text editor.
' '|
Welcome to the Helix tutorial!
Press the j key until you reach the introduction.
=================================================================
= INTRODUCTION =
=================================================================
Welcome to the Helix editor! Helix is different from editors
you might be used to in that it is modal, meaning that it has
different modes for editing text. The primary modes you will
use are Normal mode and Insert mode. While in Normal mode, the
keys you type won't actually type text. Instead, they will
perform various actions with the text. This allows for more
efficient editing. This tutor will teach you how you can make
use of Helix's modal editing features. To begin, ensure your
CapsLock key is not pressed and hold the j key until you reach
the first lesson.
=================================================================
= 1.1 BASIC CURSOR MOVEMENT =
=================================================================
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That looks good but I'm concerned it will look non-interactive or confusing on small terminal sizes: we might want to keep the note about "hold the j key until you reach the first lesson".
Maybe we can fit something small like "Welcome to the Helix tutorial! Press the j key until you reach the introduction."
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sounds good to me! I updated the mockup above.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That looks great!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sweet, I updated the PR and the screenshot in the description.
This is very cool 🎉 ! Did you do this manually? |
@archseer yeah I did it by hand using this program called monodraw. |
e2504cd
to
3e8839a
Compare
3e8839a
to
42ab294
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks great, thanks!
but i am not liking the rewriting of other letters of the name.
the new design just feels lacking any character or charm of its own, and totally confuses the eye due to lack of any pattern. I understand the motive behind - matching the graphical counterpart, but i think ascii art better left to its own will be good. |
I think it looks great and matches the design. The previous version was just quickly generated using an online tool.
If you think you can do better, open a PR. |
I noticed while running the tutor that the logo in the tutor was a little out of sync on with the logo on the website and in the repository. I adjusted the letter proportions and added the helix icon to the logo. Lemme know what y'all think. Happy to change it however folks like or delete PR if no changes wanted!
Screen shot of the proportion fitting:
Screenshot in running helix: