Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update tutor logo #5681

Merged
merged 1 commit into from
Jan 27, 2023
Merged

Conversation

g-re-g
Copy link
Contributor

@g-re-g g-re-g commented Jan 25, 2023

I noticed while running the tutor that the logo in the tutor was a little out of sync on with the logo on the website and in the repository. I adjusted the letter proportions and added the helix icon to the logo. Lemme know what y'all think. Happy to change it however folks like or delete PR if no changes wanted!

Screen shot of the proportion fitting:
Screenshot 2023-01-25 at 3 46 23 PM

Screenshot in running helix:
Screenshot 2023-01-27 at 11 13 11 AM

@the-mikedavis the-mikedavis added A-documentation Area: Documentation improvements S-waiting-on-review Status: Awaiting review from a maintainer. labels Jan 25, 2023
Copy link
Member

@the-mikedavis the-mikedavis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this is cool!

runtime/tutor Outdated
_ _ __ __
| | | | _ \ \ / /
| |_| | ___ | | (_) \ \/ /
| _ | / _ \ | | _ ) (
| | | | | __/ | | | | / /\ \
|_| |_| \___| |_| |_| /_/ \_\

A post-modern modal text editor.
_________________________________________________________________
.
###x. .|
d#####x, ,v||
'+#####v||||||
,v|||||+'. _ _ _
,v|||||^'>#### | | | | ___ | | (_) __ __
|||||^' .v#### | |___| | / \ | | _ \ \/ /
||||=..v#####P' | ___ | / ^ | | | | | \ /
''v'>#####P' | | | | | --- | | | | / \
,######/P||x. |_| |_| \___/ |_| |_| /_/\_\
####P' "x|||||,
|/' 'x||| A post-modern modal text editor.
' '|

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The change in height in this section will make this first page of the tutor too tall: each section in the tutor has the same height.

I'm not sure how to save any height in this section though. Maybe we could split some of the text below the logo into a section "0 INTRODUCTION"?

Copy link
Contributor Author

@g-re-g g-re-g Jan 25, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh interesting I never noticed. Happy to do whatever folks think works. Here's a mockup of the top of the document with all pages the same height and the introduction put into an introduction section:

                                                                 
                                                                 
       .                                                          
       ###x.        .|                                            
       d#####x,   ,v||                                            
        '+#####v||||||                                            
           ,v|||||+'.      _     _           _                    
        ,v|||||^'>####    | |   | |   ___   | | (_) __  __        
       |||||^'  .v####    | |___| |  /   \  | |  _  \ \/ /        
       ||||=..v#####P'    |  ___  | /  ^  | | | | |  \  /         
       ''v'>#####P'       | |   | | |  ---  | | | |  /  \         
       ,######/P||x.      |_|   |_|  \___/  |_| |_| /_/\_\        
       ####P' "x|||||,                                            
       |/'       'x|||    A post-modern modal text editor.        
        '           '|                                            
                                                                 
                                                                 
                 Welcome to the Helix tutorial!                  
        Press the j key until you reach the introduction.        
                                                                 
                                                                 
                                                                 
=================================================================
=                        INTRODUCTION                           =
=================================================================
                                                                 
 Welcome to the Helix editor! Helix is different from editors    
 you might be used to in that it is modal, meaning that it has   
 different modes for editing text. The primary modes you will    
 use are Normal mode and Insert mode. While in Normal mode, the  
 keys you type won't actually type text. Instead, they will      
 perform various actions with the text. This allows for more     
 efficient editing. This tutor will teach you how you can make   
 use of Helix's modal editing features. To begin, ensure your    
 CapsLock key is not pressed and hold the j key until you reach  
 the first lesson.                                               









=================================================================
=                  1.1 BASIC CURSOR MOVEMENT                    =
=================================================================

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That looks good but I'm concerned it will look non-interactive or confusing on small terminal sizes: we might want to keep the note about "hold the j key until you reach the first lesson".

Maybe we can fit something small like "Welcome to the Helix tutorial! Press the j key until you reach the introduction."

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sounds good to me! I updated the mockup above.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That looks great!

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sweet, I updated the PR and the screenshot in the description.

@archseer
Copy link
Member

This is very cool 🎉 ! Did you do this manually?

@g-re-g
Copy link
Contributor Author

g-re-g commented Jan 26, 2023

@archseer yeah I did it by hand using this program called monodraw.

@g-re-g g-re-g force-pushed the update_tutor_logo branch 2 times, most recently from e2504cd to 3e8839a Compare January 27, 2023 16:22
Copy link
Member

@the-mikedavis the-mikedavis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks great, thanks!

@the-mikedavis the-mikedavis merged commit 4a59d33 into helix-editor:master Jan 27, 2023
@goyalyashpal
Copy link
Contributor

goyalyashpal commented Feb 2, 2023

  • Awesome work for the logo - it's looking really pretty, I was dreaming about this ever since hx got a new logo
  • widening of H is also good

but i am not liking the rewriting of other letters of the name.

  • the larger X (older) makes sense as the invocation command is hx
  • the small height of eli was looking consistent and cute
  • it was forming a wave like pattern:
    large small medium small large

the new design just feels lacking any character or charm of its own, and totally confuses the eye due to lack of any pattern.

I understand the motive behind - matching the graphical counterpart, but i think ascii art better left to its own will be good.

@archseer
Copy link
Member

archseer commented Feb 3, 2023

I think it looks great and matches the design. The previous version was just quickly generated using an online tool.

the new design just feels lacking any character or charm of its own, and totally confuses the eye due to lack of any pattern.

If you think you can do better, open a PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-documentation Area: Documentation improvements S-waiting-on-review Status: Awaiting review from a maintainer.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants