Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add pem language #5797

Merged
merged 1 commit into from
Feb 7, 2023
Merged

Conversation

mtoohey31
Copy link
Contributor

This merge request adds support for PEM files. I'm not sure whether this sort of less commonly editied filetype is something we'd like to support out of the box, but I've been working with PEM files pretty frequently recently, so I figured I'd suggest adding support. Here's a screenshot with the nord theme:

helix-pem

@mtoohey31
Copy link
Contributor Author

Just realized the grammar only supports one block per file. I'll update this and mark it as ready once I've fixed that.

@mtoohey31 mtoohey31 marked this pull request as ready for review February 4, 2023 03:51
@mtoohey31
Copy link
Contributor Author

Alright, that's been fixed, and I've rebased things and resolved the merge conflicts. Here's a screenshot with multiple blocks:

helix-pem-blocks

@the-mikedavis the-mikedavis added S-waiting-on-review Status: Awaiting review from a maintainer. A-language-support Area: Support for programming/text languages labels Feb 4, 2023
Copy link
Member

@the-mikedavis the-mikedavis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's a pretty small parser (I see tens of KB on Linux) so I think it's ok to add 👍

@the-mikedavis the-mikedavis merged commit 05c5207 into helix-editor:master Feb 7, 2023
@mtoohey31 mtoohey31 deleted the feat/pem branch February 26, 2023 19:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-language-support Area: Support for programming/text languages S-waiting-on-review Status: Awaiting review from a maintainer.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants