Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

LSP: Support textDocument/prepareRename #6103

Merged
merged 8 commits into from
Mar 8, 2023
Merged

LSP: Support textDocument/prepareRename #6103

merged 8 commits into from
Mar 8, 2023

Commits on Feb 25, 2023

  1. LSP: Support textDocument/prepareRename 

    'textDocument/prepareRename' can be used by the client to ask the
server the range of the symbol under the cursor which would be changed
by a subsequent call to 'textDocument/rename' with that position.

We can use this information to fill the prompt with an accurate prefill
which can improve the UX for renaming symbols when the symbol doesn't
align with the "word" textobject. (We currently use the "word"
textobject as a default value for the prompt.)

Co-authored-by: Michael Davis <mcarsondavis@gmail.com>
    @askreet @the-mikedavis
    askreet and the-mikedavis committed Feb 25, 2023
    Configuration menu
    Copy the full SHA
    fed1fc4 View commit details
    Browse the repository at this point in the history

Commits on Feb 26, 2023

  1. clippy fixes

    @askreet
    askreet authored Feb 26, 2023
    Configuration menu
    Copy the full SHA
    da7b3bc View commit details
    Browse the repository at this point in the history

  2. rustfmt

    @askreet
    askreet committed Feb 26, 2023
    Configuration menu
    Copy the full SHA
    8e5179f View commit details
    Browse the repository at this point in the history

Commits on Feb 27, 2023

  1. Update helix-term/src/commands/lsp.rs 

    Co-authored-by: Michael Davis <mcarsondavis@gmail.com>
    @askreet @the-mikedavis
    askreet and the-mikedavis authored Feb 27, 2023
    Configuration menu
    Copy the full SHA
    9c93214 View commit details
    Browse the repository at this point in the history

  2. Update helix-term/src/commands/lsp.rs 

    Co-authored-by: Michael Davis <mcarsondavis@gmail.com>
    @askreet @the-mikedavis
    askreet and the-mikedavis authored Feb 27, 2023
    Configuration menu
    Copy the full SHA
    24913b4 View commit details
    Browse the repository at this point in the history

  3. fix clippy from suggestions

    @askreet
    askreet committed Feb 27, 2023
    Configuration menu
    Copy the full SHA
    104dc6c View commit details
    Browse the repository at this point in the history

Commits on Mar 5, 2023

  1. Update helix-term/src/commands/lsp.rs 

    Co-authored-by: Michael Davis <mcarsondavis@gmail.com>
    @askreet @the-mikedavis
    askreet and the-mikedavis authored Mar 5, 2023
    Configuration menu
    Copy the full SHA
    f9f20de View commit details
    Browse the repository at this point in the history

  2. Merge branch 'master' into lsp-prepare-rename

    @askreet
    askreet committed Mar 5, 2023
    Configuration menu
    Copy the full SHA
    f3a01dc View commit details
    Browse the repository at this point in the history