Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix diagnostic underline colors in catppuccin themes #6107

Merged
merged 2 commits into from Feb 26, 2023
Merged

Fix diagnostic underline colors in catppuccin themes #6107

merged 2 commits into from Feb 26, 2023

Conversation

ghost
Copy link

@ghost ghost commented Feb 26, 2023

The current behavior sets the foreground color, and this is very difficult to read. Instead, only the underline itself should be a different color.

@leonqadirie
Copy link
Contributor

Hi, I like the change.

Do you know the official upstream repo? We should try to keep in sync.

@the-mikedavis the-mikedavis added A-theme Area: Theme and appearence related S-waiting-on-review Status: Awaiting review from a maintainer. labels Feb 26, 2023
@ghost
Copy link
Author

ghost commented Feb 26, 2023

@leonqadirie It seems the files in this repo are already different (usage of inheritance over templates), is there a better way to keep them in sync? Perhaps a submodule of the official repo that can be fast-forwarded?

@ghost
Copy link
Author

ghost commented Feb 26, 2023

Just had a look at the upstream repo, it seems they already have this fix (slightly different syntax, but the same idea)

@the-mikedavis the-mikedavis changed the title Fix catppuccin themes Fix diagnostic underline colors in catppuccin themes Feb 26, 2023
@the-mikedavis the-mikedavis merged commit eb3086a into helix-editor:master Feb 26, 2023
@ghost ghost deleted the fix-catppuccin-themes branch February 26, 2023 21:32
estin pushed a commit to estin/helix that referenced this pull request Mar 4, 2023
wes-adams pushed a commit to wes-adams/helix that referenced this pull request Jul 4, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-theme Area: Theme and appearence related S-waiting-on-review Status: Awaiting review from a maintainer.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants