Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update onelight theme #6192

Merged
merged 3 commits into from
Mar 6, 2023
Merged

Conversation

erasin
Copy link
Contributor

@erasin erasin commented Mar 5, 2023

Reset the keyword section to complete most of the highlighting colors.

wiki has update.

20230305-225817@2x

runtime/themes/onelight.toml Outdated Show resolved Hide resolved
"ui.cursor.normal" = { fg = "white", bg = "grey" }
"ui.cursor.insert" = { fg = "white", bg = "grey" }
"ui.cursor.select" = { fg = "white", bg = "grey" }
"ui.cursor.match" = { bg = "light-grey" }
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks like this isn't defined in the palette. Maybe this could use one of the grey-* shades?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the review, here is a change to light-white, because the multi-cursor uses the grey style, here only do grayscale and multi-cursor style to distinguish.

@the-mikedavis the-mikedavis added A-theme Area: Theme and appearence related S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Mar 5, 2023
Co-authored-by: Michael Davis <mcarsondavis@gmail.com>
@erasin erasin changed the title update theme onelight Update theme onelight theme Mar 6, 2023
@the-mikedavis the-mikedavis changed the title Update theme onelight theme Update onelight theme Mar 6, 2023
@the-mikedavis the-mikedavis merged commit cfb9986 into helix-editor:master Mar 6, 2023
@erasin erasin deleted the theme-onelight branch March 6, 2023 15:36
sagnibak pushed a commit to sagnibak/helix that referenced this pull request Mar 21, 2023
wes-adams pushed a commit to wes-adams/helix that referenced this pull request Jul 4, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-theme Area: Theme and appearence related S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants