-
-
Notifications
You must be signed in to change notification settings - Fork 2.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix typos #6643
Fix typos #6643
Conversation
I have been thinking about doing something similar with https://github.com/crate-ci/typos (which fixes all typos it finds) and then running it in CI but the initial typo PR would break a lot of PRs so I am not sure if it's worth it. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks.
@pascalkuthe I have experimented with this idea of adding
I think this is not a concern because it should be easily rebase-able. I think the main problem is to decide which files should be checked and which not. For example the However if you want I can draft a PR, where we can experiment with the |
The reason I wanted it in CI is that I want to use typos locally to check/fix my commits but if there are existing errors it will endup generating a bunch of unrelated changes to existing code which is unacceptable. It's pretty straightforward to add exceptions to typos so it might still be worth it.
I think retroactively fixing typos in the CHANGELOG is quite alright. But we have a ton of testcases in helix which consist of gibberish text (like
Not quite if you rename a variable (by fixing a typo) and somebody uses that variable in their code then no conflict will show up and CI won't fail until we actually merge. We have almost 300 open PRs that's why we are usually pretty careful about renames for that reason. |
I think right now typos have too many false positive in tests, maybe we might want to exclude some stuff, but more of an issue now I think is for themes and language support, that one takes more time to review and is less automated now. We can add typos in another pull request but I will merge this for now. I think typo fix is still fine, but at least not changing name for not much benefit. |
Hello,
I have run the spellchecker across the whole codebase and found some typos.