Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Kaolin Dark, Light and Valley Dark themes #7151

Merged
merged 1 commit into from
Jul 19, 2023
Merged

Add Kaolin Dark, Light and Valley Dark themes #7151

merged 1 commit into from
Jul 19, 2023

Conversation

thlsrms
Copy link
Contributor

@thlsrms thlsrms commented May 27, 2023

Hi, I tried porting these variations based on the original Kaolin themes palette:

Kaolin Dark

kaolin-dark

Kaolin Light

kaolin-light

Kaolin Valley Dark

kaolin-valley-dark

@kirawi kirawi added the A-theme Area: Theme and appearence related label May 31, 2023
Copy link
Member

@the-mikedavis the-mikedavis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Are these themes the same except for color choices? If they're similar enough, only one of the themes needs to be written out fully and then the others can inherit that theme and overwrite the palette: https://docs.helix-editor.com/master/themes.html#inheritance (for example see the gruvbox themes)

Add some missing keys

Inherit themes from kaolin-dark and override diverging keys
@thlsrms
Copy link
Contributor Author

thlsrms commented Jun 13, 2023

Are these themes the same except for color choices? If they're similar enough, only one of the themes needs to be written out fully and then the others can inherit that theme and overwrite the palette: https://docs.helix-editor.com/master/themes.html#inheritance (for example see the gruvbox themes)

Makes sense. I pushed the changes using inheritance and overriding the palette and differing properties for the light and valley-dark variants.

@archseer archseer merged commit d52b790 into helix-editor:master Jul 19, 2023
@zoedsoupe
Copy link

i would like to ask for symbols support like for atoms in Elixir, Ruby’s symbol and Clojure’s keyword. they’re mean to semantically have the same color as modules, or in other worlds, a different color from common “strings”. how I could implement it?

@the-mikedavis
Copy link
Member

You'll want to theme the "string.special.symbol" key:

# ~/.config/helix/themes/mytheme.toml
inherits = "kaolin-dark"
"string.special.symbol" = "info"

mtoohey31 pushed a commit to mtoohey31/helix that referenced this pull request Jun 2, 2024
Add some missing keys

Inherit themes from kaolin-dark and override diverging keys
smortime pushed a commit to smortime/helix that referenced this pull request Jul 10, 2024
Add some missing keys

Inherit themes from kaolin-dark and override diverging keys
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-theme Area: Theme and appearence related
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants