Add treesitter textobjects #728
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
archseer
requested changes
Sep 8, 2021
sudormrfbin
force-pushed
the
treesitter-objects
branch
2 times, most recently
from
3704d71
to
a6a3724
Compare
Only for Go, Python and Rust for now.
Only has functions and class objects as of now.
sudormrfbin
force-pushed
the
treesitter-objects
branch
from
a6a3724
to
400af6f
Compare
pickfire
reviewed
Sep 11, 2021
pickfire
reviewed
Sep 11, 2021
Only parameter.inside is implemented now, parameter.around will probably require custom predicates akin to nvim' `make-range` since we want to select a trailing comma too (a comma will be an anonymous node and matching against them doesn't work similar to named nodes)
|
I've added |
|
The default binding for parameter object is |
archseer
requested changes
Sep 30, 2021
| let selection = doc.selection(view.id).clone().transform(|range| { | ||
| match ch { | ||
| 'w' => textobject::textobject_word(text, range, objtype, count), | ||
| 'c' => textobject_treesitter("class", range), |
There was a problem hiding this comment.
I still think we want a better name than class here, maybe type?
There was a problem hiding this comment.
I left a comment up here about the naming, and I think we should aim for an intuitive name. I think "type" might be a bit misleading ? Though I guess the same can be said for "class" :|
sudormrfbin
force-pushed
the
treesitter-objects
branch
from
361841c
to
a652a1e
Compare
archseer
approved these changes
Oct 23, 2021
6 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ffor functions andcfor classes, so for examplemacwill select around the current class. Currently only queries for Rust, Python and Golang are included.TODO
Future Works