Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bail if no language servers support workspace symbols #7286

Merged
merged 1 commit into from
Jun 8, 2023
Merged

Bail if no language servers support workspace symbols #7286

merged 1 commit into from
Jun 8, 2023

Conversation

the-mikedavis
Copy link
Member

The behavior prior to this commit opened the picker and then showed the error. We can check the feature availability before performing the first query to prevent opening up the picker unnecessarily.

@the-mikedavis
Bail if no language servers support workspace symbols
7bec360 
The behavior prior to this commit opened the picker and then showed
the error. We can check the feature availability before performing the
first query to prevent opening up the picker unnecessarily.
@the-mikedavis the-mikedavis added E-easy Call for participation: Experience needed to fix: Easy / not much A-language-server Area: Language server client S-waiting-on-review Status: Awaiting review from a maintainer. labels Jun 7, 2023
pascalkuthe
pascalkuthe approved these changes Jun 7, 2023
View reviewed changes
Copy link
Member

@pascalkuthe pascalkuthe left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just because I was confused at first and have this written down somewhere: This is necessary because the workspace symbol picker is a dynamic picker (the normal symbol picker isn't). Thanks!

@archseer archseer merged commit d442712 into master Jun 8, 2023
@archseer archseer deleted the bail-workspace-symbols-if-unavailable branch June 8, 2023 00:48
Triton171 pushed a commit to Triton171/helix that referenced this pull request Jun 18, 2023
@the-mikedavis @Triton171
Bail if no language servers support workspace symbols (helix-editor#7286
5f26d63 
)
wes-adams pushed a commit to wes-adams/helix that referenced this pull request Jul 4, 2023
@the-mikedavis @wes-adams
Bail if no language servers support workspace symbols (helix-editor#7286
c01c688 
)
mtoohey31 pushed a commit to mtoohey31/helix that referenced this pull request Jun 2, 2024
@the-mikedavis @mtoohey31
Bail if no language servers support workspace symbols (helix-editor#7286
0ce16b9 
)
smortime pushed a commit to smortime/helix that referenced this pull request Jul 10, 2024
@the-mikedavis
Bail if no language servers support workspace symbols (helix-editor#7286
87121d5 
)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pascalkuthe pascalkuthe pascalkuthe approved these changes

Assignees
No one assigned
Labels
A-language-server Area: Language server client E-easy Call for participation: Experience needed to fix: Easy / not much S-waiting-on-review Status: Awaiting review from a maintainer.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@the-mikedavis @pascalkuthe @archseer