Mark buffers created from stdin as modified #7431
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
the-mikedavis
added
C-bug
the-mikedavis
commented
Jun 23, 2023
| @@ -493,6 +471,81 @@ pub fn from_reader<R: std::io::Read + ?Sized>( | |||
| Ok((rope, encoding, has_bom)) | |||
| } | |||
|
|
|||
| pub fn read_to_string<R: std::io::Read + ?Sized>( | |||
There was a problem hiding this comment.
This would also be useful for #3966
This resolves some confusing behavior where a scratch document created by piping into hx is discarded when navigating away from that document. We discard any scratch documents that are not modified and the original `Editor::new_file_from_stdin` would create unmodified documents. We refactor this function to create an empty document first and then to apply the text from stdin as a change.
the-mikedavis
force-pushed
the
stdin-modified
branch
from
53adba1
to
6642d9b
Compare
wes-adams
pushed a commit
to wes-adams/helix
that referenced
this pull request
Jul 4, 2023
This resolves some confusing behavior where a scratch document created by piping into hx is discarded when navigating away from that document. We discard any scratch documents that are not modified and the original `Editor::new_file_from_stdin` would create unmodified documents. We refactor this function to create an empty document first and then to apply the text from stdin as a change.
shaleh
added a commit
to shaleh/helix
that referenced
this pull request
Apr 15, 2024
Resurrects helix-editor#3966. This is 100% @idursun's work. Using read_to_string from helix-editor#7431. Co-authored-by: ibrahim@dursun.cc
shaleh
added a commit
to shaleh/helix
that referenced
this pull request
Apr 16, 2024
Resurrects helix-editor#3966. This is 100% @idursun's work. Using read_to_string from helix-editor#7431. Co-authored-by: ibrahim@dursun.cc
mtoohey31
pushed a commit
to mtoohey31/helix
that referenced
this pull request
Jun 2, 2024
This resolves some confusing behavior where a scratch document created by piping into hx is discarded when navigating away from that document. We discard any scratch documents that are not modified and the original `Editor::new_file_from_stdin` would create unmodified documents. We refactor this function to create an empty document first and then to apply the text from stdin as a change.
smortime
pushed a commit
to smortime/helix
that referenced
this pull request
Jul 10, 2024
This resolves some confusing behavior where a scratch document created by piping into hx is discarded when navigating away from that document. We discard any scratch documents that are not modified and the original `Editor::new_file_from_stdin` would create unmodified documents. We refactor this function to create an empty document first and then to apply the text from stdin as a change.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This resolves some confusing behavior where a scratch document created by piping into hx is discarded when navigating away from that document.
We discard any scratch documents that are not modified and the original
Editor::new_file_from_stdinwould create unmodified documents. We refactor this function to create an empty document first and then to apply the text from stdin as a change.This comes out of the discussion in #3306
Closes #3306
Closes #3305